to_chars.cpp, 2 digits at a time and avoiding reversal loop - #2781
Merged
Conversation
Member
|
Running tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR propose an improvement of
src/to_chars::dragonbox()by using 2-at-a-time method (Alexandrescu, "Three Optimization Tips for C++", 2012) and back-to-front+memcpy write in buffer to avoid reversal loop. Reducing by 3x the number of loop iterations in this function.Context
This PR continue:
Issues related to this PR:
100% on tests with:
benchmarked with
benchmark/car_builder/benchmark_car_builder.cpp:Bench
master:
this PR:
Notes
to_chars.cppof this PR, overbenchmark/car_builder/benchmark_car_builder.cpp, drop from 0.95 ns/char to 0.85 ns/char if merged with to_chars.cpp, fast path to avoid i128 emulation when possible #2780to_chars.cpp::dragonbox()doc as comments.jeaiiialgorithm insidedragonbox()to avoid completly modulo and division but it become 0.02ns/char slower than this PR.