fix DeepSeek provider routing and refresh desktop docs#24
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR improves LLM provider routing (notably DeepSeek) across the desktop runner and runtime config logging, and refreshes desktop-facing documentation/UI messaging to better reflect when settings changes take effect.
Changes:
- Fix desktop (Tauri) environment variable injection to isolate credentials to the selected LLM provider and avoid leaking/cross-wiring API keys.
- Add runtime logging of the effective LLM configuration with safe endpoint redaction, plus tests covering DeepSeek payload overrides and URL sanitization.
- Normalize settings before persistence/execution and improve “settings saved” notices for running vs queued tasks; refresh README desktop screenshot.
Reviewed changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/test_desktop_runner_config.py | Adds regression tests for DeepSeek payload routing and endpoint redaction helpers. |
| src-tauri/src/main.rs | Adjusts desktop child-process env handling to isolate provider credentials; adds supporting tests. |
| README.md | Adds a desktop workspace screenshot section for updated docs. |
| frontend/src/lib/i18n.ts | Introduces new localized “settings saved” notices for running/queued tasks. |
| frontend/src/features/settings/lib/normalize-settings.ts | Adds a helper to canonicalize provider routing fields prior to saving/executing. |
| frontend/src/features/settings/lib/normalize-settings.test.ts | Adds unit coverage for settings normalization behavior. |
| frontend/src/components/task-center/context.tsx | Applies normalization on save and sets contextual “settings saved” notices based on queue state. |
| frontend/server/run_analysis.py | Ensures payload provider override is applied correctly and emits a sanitized runtime LLM config message. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+3
to
+13
| export function normalizeSettingsForSave(settings: GlobalSettings): GlobalSettings { | ||
| return { | ||
| ...settings, | ||
| llmProvider: settings.llmProvider.trim().toLowerCase(), | ||
| backendUrl: settings.backendUrl.trim(), | ||
| quickThinkLlm: settings.quickThinkLlm.trim(), | ||
| deepThinkLlm: settings.deepThinkLlm.trim(), | ||
| apiKey: settings.apiKey.trim(), | ||
| alphaVantageApiKey: settings.alphaVantageApiKey.trim(), | ||
| }; | ||
| } |
Comment on lines
+1255
to
+1259
| fn remove(&mut self, name: &str) { | ||
| if !self.removed_vars.iter().any(|item| item == name) { | ||
| self.removed_vars.push(name.to_string()); | ||
| } | ||
| } |
Signed-off-by: simonguo <simonguo.2009@gmail.com>
simonguo
force-pushed
the
agent/fix-deepseek-provider-routing
branch
from
July 24, 2026 05:54
4c33916 to
12a968f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
Signed-off-byfor the DCOSecurity and data impact
Screenshots