Skip to content

T and p beams#37

Merged
thibautlouis merged 10 commits intomainfrom
T_and_P_beams
Oct 31, 2023
Merged

T and p beams#37
thibautlouis merged 10 commits intomainfrom
T_and_P_beams

Conversation

@thibautlouis
Copy link
Copy Markdown
Collaborator

No description provided.

@thibautlouis thibautlouis requested a review from xgarrido October 29, 2023 11:54
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Oct 29, 2023

Codecov Report

Attention: 38 lines in your changes are missing coverage. Please review.

Comparison is base (5d21b02) 16.79% compared to head (c1bb890) 17.61%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #37      +/-   ##
==========================================
+ Coverage   16.79%   17.61%   +0.82%     
==========================================
  Files          14       14              
  Lines        1459     1476      +17     
==========================================
+ Hits          245      260      +15     
- Misses       1214     1216       +2     
Files Coverage Δ
pspipe_utils/pspipe_list.py 0.00% <0.00%> (ø)
pspipe_utils/misc.py 27.77% <33.33%> (+27.77%) ⬆️
pspipe_utils/best_fits.py 37.19% <12.50%> (-1.08%) ⬇️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Comment thread pspipe_utils/misc.py Outdated
Comment thread pspipe_utils/best_fits.py Outdated
elif len(na.split("&")) == 3:
sv_a, ar_a, split_a = na.split("&")
sv_b, ar_b, split_b = nb.split("&")
elif len(ms_a.split("&")) == 3:
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here you should also used the parameter char when splitting. You can also write this part in a simpler way

tuple_a = ms_a.split(char)
tuple_b = ms_b.split(char)
if len(tuple_a) == 2:
  sv_a, ar_a = tuple_a
  sv_b, ar_b = tuple_b
  ...
elif len(tuple_a) == 3:
  sv_a, ar_a, split_a = tuple_a
else:
  raise ValueError()

I should also add an exception in case the split does not work as expected, to understand what's going on

Comment thread pspipe_utils/best_fits.py Outdated
Comment thread pspipe_utils/misc.py
@thibautlouis thibautlouis merged commit efda48b into main Oct 31, 2023
@xgarrido xgarrido deleted the T_and_P_beams branch October 31, 2023 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants