Skip to content

Fixes the broken tests - #18

Merged
Sulla2012 merged 1 commit into
jorlo/ephem-from-filesfrom
fix-broken-tests
Apr 23, 2026
Merged

Fixes the broken tests#18
Sulla2012 merged 1 commit into
jorlo/ephem-from-filesfrom
fix-broken-tests

Conversation

@JBorrow

@JBorrow JBorrow commented Apr 23, 2026

Copy link
Copy Markdown
Member

Fixes the broken tests.

@JBorrow
JBorrow requested a review from Sulla2012 April 23, 2026 17:57

@Sulla2012 Sulla2012 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me but why do we need the pyarrow dependency?

@JBorrow

JBorrow commented Apr 23, 2026

Copy link
Copy Markdown
Member Author

It is necessary to read parquet files

@Sulla2012

Copy link
Copy Markdown
Collaborator

Do we actually read any parquet files tho? I guess we'll want to

@JBorrow

JBorrow commented Apr 23, 2026

Copy link
Copy Markdown
Member Author

read_jpl.py has import pyarrow.parquet as pq

@Sulla2012

Copy link
Copy Markdown
Collaborator

I'm looking at the wrong branch it totally does.

@Sulla2012
Sulla2012 merged commit 032e325 into jorlo/ephem-from-files Apr 23, 2026
3 checks passed
@Sulla2012
Sulla2012 deleted the fix-broken-tests branch April 23, 2026 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants