Skip to content

PysmurfController: fix uxm_setup arg bug and default to modify_attens… - #1102

Draft
mhasself wants to merge 1 commit into
mainfrom
mhasself/fix-uxm-setup
Draft

PysmurfController: fix uxm_setup arg bug and default to modify_attens…#1102
mhasself wants to merge 1 commit into
mainfrom
mhasself/fix-uxm-setup

Conversation

@mhasself

@mhasself mhasself commented Sep 1, 2026

Copy link
Copy Markdown
Member

Description

In uxm_setup:

  1. Typo bugfix. Probably was broken.
  2. Set a default value for modify_attens. This is rarely needed.

Motivation and Context

Running uxm_setup through OCS is desirable because then we can more easily enforce that PysmurfMonitor is running. That's beyond the scope of this PR but here we at least help make it possible to do so.

How Has This Been Tested?

Untested, but unlikely to make anything worse than it was before. And there's some chance it will work.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@mhasself

mhasself commented Sep 1, 2026

Copy link
Copy Markdown
Member Author

Draft while waiting for confirmation on best default args. Also would be good if someone tested this somehow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant