CodeMirror stack 1/4: upgrade to latest 6.x, fix sql() option names, rollup build#2834
Draft
asg017 wants to merge 2 commits into
Draft
CodeMirror stack 1/4: upgrade to latest 6.x, fix sql() option names, rollup build#2834asg017 wants to merge 2 commits into
asg017 wants to merge 2 commits into
Conversation
codemirror 6.0.1 -> 6.0.2, @codemirror/lang-sql 6.3.3 -> 6.10.0 (autocomplete 6.20.3, view 6.43.6, state 6.7.1). defaultTableName/defaultSchemaName were never valid SQLConfig options; the real names are defaultTable/defaultSchema. Also enables caseInsensitiveIdentifiers on the SQLite dialect. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
cm-editor-6.0.1.{js,bundle.js} -> cm-editor.{js,bundle.js}; new
npm run build:codemirror replaces the documented rollup one-liner.
Cache busting already handled by the static() template helper's
?_hash= content hash.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This was referenced Jul 10, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2834 +/- ##
=====================================
Coverage 0.00% 0.00%
=====================================
Files 73 73
Lines 12208 12208
=====================================
Misses 12208 12208 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part 1 of the CodeMirror stack (integration view: #2833). Pure maintenance — no behavior change beyond a fresher editor.
What
codemirror6.0.1 → 6.0.2,@codemirror/lang-sql6.3.3 → 6.10.0, transitives refreshed (autocomplete 6.20.3, view 6.43.6, state 6.7.1). Everything is still major-version 6 — no breaking changes; no CodeMirror 7 exists.sql()was called withdefaultTableName/defaultSchemaName, which have never been valid lang-sql options (the real names aredefaultTable/defaultSchema). They were silently ignored — nothing supplied them, but part 2 of the stack makesdefaultTableload-bearing.caseInsensitiveIdentifiers: trueon the curated SQLite dialect (lang-sql ≥ 6.7): stops completions auto-quoting mixed-case identifiers.cm-editor-6.0.1.{js,bundle.js}→cm-editor.{js,bundle.js}(git records clean renames), so upgrades no longer require editing a template. Cache busting was already handled by thestatic()template helper's?_hash=content hash.rollup.config.mjs+npm run build:codemirrorreplace the six-flag one-liner previously documented indocs/contributing.rst; docs rewritten accordingly.Review notes
npm install && npm run build:codemirror(byte-identical output).Testing
Full pytest suite green. Manual QA: editor mounts on
/fixtures, completion popup, Shift/Meta-Enter submit, Format SQL, resize handle.The stack
/-/editor-schema.json,defaultTabledatasette-sql-editorESM primitives<datasette-sql-editor>element + core-page dogfoodEach PR is based on the previous branch; merge top-down, retargeting the next base to
mainas each lands. Bundle files (*.bundle.js) conflict on rebase by nature — resolve by re-runningnpm run build:codemirror, never by merging. Integration view of the whole branch: #2833.🤖 Generated with Claude Code