Skip to content

ASTRO-DF Refactor#149

Merged
Grochocinski merged 9 commits intodevelopmentfrom
astrodf_refactor
Mar 10, 2025
Merged

ASTRO-DF Refactor#149
Grochocinski merged 9 commits intodevelopmentfrom
astrodf_refactor

Conversation

@Grochocinski
Copy link
Copy Markdown
Collaborator

  • Moved a lot of variables to instance variables for the class so they wouldn't need to be passed back and forth repeatedly between functions (iterate() requiring 13 values and returning 10 was driving me crazy)
  • Extracted common code into functions for increased clarity, the most notable being the adaptive sampling functionality
  • Added clamp_with_epsilon function to optimize box constraints
  • Changed divide-by-zero behavior to avoid introducing misleading/incorrect values into datasets. Apparently this also fixed the one remaining linux/windows test discrepancy mentioned in Reimplement testing #145, so we can close Floating Point Calculations are not Standardized between Systems #80 😎
  • General optimization

@Grochocinski Grochocinski linked an issue Mar 9, 2025 that may be closed by this pull request
@Grochocinski Grochocinski merged commit f10f2f3 into development Mar 10, 2025
@Grochocinski Grochocinski deleted the astrodf_refactor branch March 10, 2025 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Floating Point Calculations are not Standardized between Systems

1 participant