Improve Divide-By-Zero Handling#150
Merged
Grochocinski merged 5 commits intodevelopmentfrom Mar 10, 2025
Merged
Conversation
…ed affected tests
Collaborator
Author
|
Update: after reviewing the divide-by-zero handling in ASTRO-DF, I no longer think any updates to it need to be made as previously thought |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
make_nonzero()function to make checking/correcting potential divide-by-zero errors easierpost_normalize()to utilize this new function0s instead ofnans afterpost_normalize()behavior changedASTRO-DF behavior still needs refactored (pending merge of PR #149 into dev)