Skip to content

Improve Divide-By-Zero Handling#150

Merged
Grochocinski merged 5 commits intodevelopmentfrom
improve_db0_handling
Mar 10, 2025
Merged

Improve Divide-By-Zero Handling#150
Grochocinski merged 5 commits intodevelopmentfrom
improve_db0_handling

Conversation

@Grochocinski
Copy link
Copy Markdown
Collaborator

@Grochocinski Grochocinski commented Mar 10, 2025

  • Introduced make_nonzero() function to make checking/correcting potential divide-by-zero errors easier
  • Updated Strong and SPSA solvers and post_normalize() to utilize this new function
  • Regenerated some CNTNEWS1 and IRONORECONT1 test results that had 0s instead of nans after post_normalize() behavior changed
  • Regenerated test results for EXAMPLE1 with SPSA as the new divide-by-0 behavior slightly changed run results for SPSA. Other tests for SPSA were not affected and thus didn't need regenerated.

ASTRO-DF behavior still needs refactored (pending merge of PR #149 into dev)

@Grochocinski Grochocinski self-assigned this Mar 10, 2025
@Grochocinski Grochocinski merged commit f8d8477 into development Mar 10, 2025
@Grochocinski Grochocinski deleted the improve_db0_handling branch March 10, 2025 09:14
@Grochocinski
Copy link
Copy Markdown
Collaborator Author

Update: after reviewing the divide-by-zero handling in ASTRO-DF, I no longer think any updates to it need to be made as previously thought

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant