Fix a bug with the yHhQuintilesMonthC5 variable (BenefitUnit.csv) in the first year of the simulation - #500
Merged
Merged
Conversation
…the first year of the simulation Before, in the BenefitUnit.csv output file, for the first year of the simulation, the only income quintiles in the dataset were Q1 and Q5. Now, it extracts household income-quintile assignment into `BenefitUnit.updateIncomeQuintile()` and reuses it where non-benefit income is computed, removing duplicated branching logic. It also updates all benefit units’ quintile labels in `SimPathsCollector` after recalculating yearly percentile cutoffs (from year 2 onward), so quintile classification stays aligned with current-year distribution thresholds.
Refreshes expected results for integration tests by updating AlignmentAdjustmentFactors1, EmploymentStatistics1, HealthStatistics1, Statistics1, and Statistics21.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before, in the BenefitUnit.csv output file, for the first year of the simulation, the only income quintiles in the dataset were Q1 and Q5. Now, it extracts household income-quintile assignment into
BenefitUnit.updateIncomeQuintile()and reuses it where non-benefit income is computed, removing duplicated branching logic. It also updates all benefit units’ quintile labels inSimPathsCollectorafter recalculating yearly percentile cutoffs (from year 2 onward), so quintile classification stays aligned with current-year distribution thresholds.