deps: bump golang.org/x/net 0.54.0 → 0.55.0 (fixes 6/8 Scorecard vulns)#289
Merged
Conversation
Closes 6 of 8 OpenSSF Scorecard Vulnerabilities-probe warnings (`osv-scanner` against the full module tree, no reachability): GO-2026-5025 net/html — namespaced elements in foreign content GO-2026-5026 net/idna — Punycode → ASCII-only label accepted GO-2026-5027 net/html — HTML elements in foreign content (XSS) GO-2026-5028 net/html — CPU DoS on arbitrary HTML GO-2026-5029 net/html — character refs in DOCTYPE nodes GO-2026-5030 net/html — duplicate attributes → XSS All six are fixed in golang.org/x/net v0.55.0 (released 2026-05-22). OSV reports zero advisories against v0.55.0. Remaining 2 warnings — GO-2022-0635 / GO-2022-0646 (aws-sdk-go v1 s3crypto, CVE-2020-8911/8912) — have NO fix in the v1 line; the AWS SDK Go team only patched s3crypto in v2. Both `github.com/pulumi/pulumi/pkg/v3@latest` and `gocloud.dev@latest` still pull aws-sdk-go v1 transitively, so we can't drop it without dropping Pulumi or gocloud.dev. Both advisories are already documented as `not_affected` / `vulnerable_code_not_in_execute_path` in vex/openvex.json and govulncheck reachability confirms 0 calls into the s3crypto subpackage. Scorecard's `hasOSVVulnerabilities` probe does not consume OpenVEX, so the warnings will persist until upstream migrates off aws-sdk-go v1. Signed-off-by: Dmitrii Creed <creeed22@gmail.com>
Semgrep Scan ResultsRepository:
Scanned at 2026-05-24 14:26 UTC |
Security Scan ResultsRepository:
Scanned at 2026-05-24 14:27 UTC |
smecsia
approved these changes
May 24, 2026
4 tasks
Cre-eD
added a commit
that referenced
this pull request
May 24, 2026
…verage (#291) ## Summary Cuts the 10 Semgrep WARNING findings the job has been posting on every PR (and on #289) by disabling two registry-pack rules whose threat models don't apply to SC code. Reachability-aware replacement coverage ships in [actions#23](simple-container-com/actions#23). ## Findings being silenced All 10 are pre-existing intentional patterns: **MD5-as-fingerprint (7)** — `use-of-md5` fires on every `md5.Sum()` regardless of context. SC call sites are: | File | Use | |---|---| | [pkg/clouds/pulumi/aws/static_website.go:166](pkg/clouds/pulumi/aws/static_website.go#L166) | upload-bundle checksum (S3 etag-style) | | [pkg/clouds/pulumi/gcp/bucket_uploader.go:55](pkg/clouds/pulumi/gcp/bucket_uploader.go#L55) | upload-bundle checksum (S3 etag-style) | | [pkg/clouds/pulumi/gcp/gke_autopilot_stack.go:243,251](pkg/clouds/pulumi/gcp/gke_autopilot_stack.go#L243), [pkg/clouds/pulumi/kubernetes/kube_run.go:225,233](pkg/clouds/pulumi/kubernetes/kube_run.go#L225) | K8s annotation hash for Caddy restart trigger | | [pkg/clouds/pulumi/cloudflare/registrar.go:71](pkg/clouds/pulumi/cloudflare/registrar.go#L71) | dedup suffix for Pulumi resource names on duplicate-name DNS records | **yaml-into-interface{} (3)** — `unsafe-deserialization-interface` is calibrated to Python pickle/yaml.load (executes on unmarshal). Go's `yaml.v3` / `encoding/json` don't execute. SC call sites: | File | Use | |---|---| | [pkg/assistant/chat/commands_project.go:943](pkg/assistant/chat/commands_project.go#L943) | obfuscate embedded YAML credentials before logging | | [pkg/assistant/security/secure_file_reader.go:93,339](pkg/assistant/security/secure_file_reader.go#L93) | redact secrets in user YAML before logging | The SC team already documented this exact reasoning in `go-canon.yml` round-6 triage, where they dropped their own equivalent yaml-unmarshal rule. ## What still catches the real threats Disabling these two rules does NOT lose coverage; the genuine patterns are caught by narrower rules in `go-canon.yml`: - **MD5 in real crypto context** — new `go-md5-in-crypto-context` rule (actions#23) fires on `hmac.New(md5.New, ...)` and on md5 result assigned to a variable named `mac` / `hmac` / `signature` / `tag` / `auth` / `token` / `password` / `digest`. - **Untrusted-source → unmarshal → exec** — taint-aware coverage in `p/golang` registry pack remains enabled. Only the generic shape-only rule is disabled. ## Dependencies ⚠ **Pinned to a branch SHA on actions.** The reusable-workflow ref currently points at `2a7604ddac4fd9f912a1ab6896ac87c5b07bc537` (the head of actions#23). Before merging this PR, **bump the pin to the main-merge SHA** that actions#23 produces. ## Test plan - [ ] actions#23 merges and CI is green - [ ] Bump reusable-workflow SHA pin to actions main-merge commit - [ ] CI re-run: Semgrep posts 0 WARNING findings - [ ] Spot-check: `go-md5-in-crypto-context` still fires if someone writes `hmac.New(md5.New, key)` — verified in actions#23 fixtures (8 new cases) --------- Signed-off-by: Dmitrii Creed <creeed22@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bumps
golang.org/x/netindirect dep from v0.54.0 → v0.55.0 to close 6 of the 8 OpenSSF ScorecardVulnerabilities-probe warnings onmain.Vuln-to-bump mapping
golang.org/x/net/html(namespaced elements in foreign content)golang.org/x/net/idna(Punycode → ASCII-only label)golang.org/x/net/html(HTML in foreign content → XSS)golang.org/x/net/html(parser CPU DoS)golang.org/x/net/html(character refs in DOCTYPE)golang.org/x/net/html(duplicate attributes → XSS)github.com/aws/aws-sdk-go/service/s3/s3crypto(CVE-2020-8911)github.com/aws/aws-sdk-go/service/s3/s3crypto(CVE-2020-8912)OSV confirms
golang.org/x/net@0.55.0carries zero open advisories.Why the 2 aws-sdk-go v1 vulns can't be bumped here
The s3crypto vulnerabilities were never patched in the v1 line — AWS only fixed them in aws-sdk-go-v2. We don't import
aws/aws-sdk-godirectly. It's pulled in transitively by:github.com/pulumi/pulumi/pkg/v3(latest v3.243.0 still requiresaws-sdk-go v1.50.36)github.com/pulumi/esc(latest v0.24.0 — same)gocloud.dev(latest v0.45.0 still requiresaws-sdk-go v1.55.8)So we can't remove the v1 transitive without dropping Pulumi or gocloud.dev. Both advisories are already declared
not_affected/vulnerable_code_not_in_execute_pathinvex/openvex.json—govulncheck -mode=source ./...reports zero reachable calls intos3crypto. Scorecard'shasOSVVulnerabilitiesprobe does not consume OpenVEX (verified againstprobes/hasOSVVulnerabilities/impl.go), so these two warnings will continue to fire onmainuntil upstream migrates.Test plan
go mod tidyclean (no other deps shifted)go build ./...succeeds