chore(ci): bump the github-actions group across 1 directory with 8 updates - #371
Open
dependabot[bot] wants to merge 1 commit into
Open
chore(ci): bump the github-actions group across 1 directory with 8 updates#371dependabot[bot] wants to merge 1 commit into
dependabot[bot] wants to merge 1 commit into
Conversation
…dates Bumps the github-actions group with 8 updates in the / directory: | Package | From | To | | --- | --- | --- | | [actions/attest-build-provenance](https://github.com/actions/attest-build-provenance) | `4.1.0` | `4.1.1` | | [docker/setup-buildx-action](https://github.com/docker/setup-buildx-action) | `4.1.0` | `4.2.0` | | [docker/build-push-action](https://github.com/docker/build-push-action) | `7.2.0` | `7.3.0` | | [github/codeql-action/init](https://github.com/github/codeql-action) | `4.36.2` | `4.37.3` | | [github/codeql-action/autobuild](https://github.com/github/codeql-action) | `4.36.2` | `4.37.3` | | [github/codeql-action/analyze](https://github.com/github/codeql-action) | `4.36.2` | `4.37.3` | | [ossf/scorecard-action](https://github.com/ossf/scorecard-action) | `2.4.3` | `2.4.4` | | [github/codeql-action/upload-sarif](https://github.com/github/codeql-action) | `4.36.2` | `4.37.3` | Updates `actions/attest-build-provenance` from 4.1.0 to 4.1.1 - [Release notes](https://github.com/actions/attest-build-provenance/releases) - [Changelog](https://github.com/actions/attest-build-provenance/blob/main/RELEASE.md) - [Commits](actions/attest-build-provenance@a2bbfa2...0f67c3f) Updates `docker/setup-buildx-action` from 4.1.0 to 4.2.0 - [Release notes](https://github.com/docker/setup-buildx-action/releases) - [Commits](docker/setup-buildx-action@d7f5e7f...bb05f3f) Updates `docker/build-push-action` from 7.2.0 to 7.3.0 - [Release notes](https://github.com/docker/build-push-action/releases) - [Commits](docker/build-push-action@f9f3042...53b7df9) Updates `github/codeql-action/init` from 4.36.2 to 4.37.3 - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@8aad20d...e4fba86) Updates `github/codeql-action/autobuild` from 4.36.2 to 4.37.3 - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@8aad20d...e4fba86) Updates `github/codeql-action/analyze` from 4.36.2 to 4.37.3 - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@8aad20d...e4fba86) Updates `ossf/scorecard-action` from 2.4.3 to 2.4.4 - [Release notes](https://github.com/ossf/scorecard-action/releases) - [Changelog](https://github.com/ossf/scorecard-action/blob/main/RELEASE.md) - [Commits](ossf/scorecard-action@4eaacf0...2d11466) Updates `github/codeql-action/upload-sarif` from 4.36.2 to 4.37.3 - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@8aad20d...e4fba86) --- updated-dependencies: - dependency-name: actions/attest-build-provenance dependency-version: 4.1.1 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: github-actions - dependency-name: docker/setup-buildx-action dependency-version: 4.2.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: github-actions - dependency-name: docker/build-push-action dependency-version: 7.3.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: github-actions - dependency-name: github/codeql-action/init dependency-version: 4.37.3 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: github-actions - dependency-name: github/codeql-action/autobuild dependency-version: 4.37.3 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: github-actions - dependency-name: github/codeql-action/analyze dependency-version: 4.37.3 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: github-actions - dependency-name: ossf/scorecard-action dependency-version: 2.4.4 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: github-actions - dependency-name: github/codeql-action/upload-sarif dependency-version: 4.37.3 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: github-actions ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
Bot
requested review from
Cre-eD,
Laboratory,
smecsia and
universe-ops
as code owners
July 27, 2026 09:24
Semgrep Scan ResultsRepository:
Scanned at 2026-07-27 09:25 UTC |
Security Scan ResultsRepository:
Scanned at 2026-07-27 09:26 UTC |
📊 Statement coverageMeasured on the documented included set (see
Baseline: |
6 tasks
Cre-eD
added a commit
that referenced
this pull request
Aug 3, 2026
…lities 8 → 10) (#372) ## Summary OpenSSF Scorecard's **Vulnerabilities** check is at **8/10** with 8 open advisories. This PR takes it to **10/10**. - **7 fixed by version bump** — 3 Go, 4 Python (all severities, nothing deferred). - **1 unfixable by design** — `GO-2026-5932` has `introduced: 0` and no fix event in OSV. Declared `not_affected` with reachability evidence. - **2 stale suppressions retired** — `GO-2022-0635` / `GO-2022-0646` no longer apply; removed rather than carried forward. `osv-scanner scan source -r .` → **No issues found** (was 8). Scorecard runs the same scanner (`osvscanner.DoScan` via `clients/osv.go`) against the repo root, so the check flips on merge to `main`. ## Fixed | Package | Old → New | Advisory | Sev | Where | |---|---|---|---|---| | `github.com/klauspost/compress` | 1.18.4 → 1.18.7 | GO-2026-5841 / GHSA-259r-337f-4rfw — OOB read in `s2` | HIGH | `go.mod` (indirect) | | `google.golang.org/grpc` | 1.81.1 → 1.82.1 | GO-2026-6061 / GHSA-hrxh-6v49-42gf — xDS RBAC + HTTP/2 server | HIGH | `go.mod` (indirect) | | `click` | 8.1.8 → 8.4.2 | PYSEC-2026-2132 / CVE-2026-7246 | MEDIUM | `docs/requirements.txt` | | `pymdown-extensions` | 10.21.3 → 11.0.1 | GHSA-9xwg-3r6f-jcx2 / CVE-2026-61632 — `b64` path traversal | MEDIUM | `docs/requirements.txt` | | `setuptools` | 82.0.1 → 83.0.0 | PYSEC-2026-3447 / CVE-2026-59890 | MEDIUM | `docs/requirements.txt` | | `soupsieve` | 2.8.3 → 2.9.1 | PYSEC-2026-3071 / CVE-2026-49476 — memory exhaustion | HIGH | `docs/requirements.txt` | | `soupsieve` | 2.8.3 → 2.9.1 | PYSEC-2026-3072 / CVE-2026-49477 — ReDoS in selector parser | HIGH | `docs/requirements.txt` | Side-effect bumps pulled in by the above: `x/crypto` 0.53.0 → 0.54.0, `x/sys` 0.46.0 → 0.47.0, `x/term` 0.44.0 → 0.45.0, `opentelemetry-operations-go/detectors/gcp` 1.31.0 → 1.32.0, `contrib/detectors/gcp` 1.42.0 → 1.43.0, plus the `tools.go` chain (see *CI ordering* below). ### How the Python side was done `docs/requirements.in` gains explicit patched floors for the four packages, following the pattern already established for `requests` / `urllib3` after #264 — pinning the floor in the `.in` file is what stops a future `pip-compile` from silently resolving back to a vulnerable version. `docs/requirements.txt` was then regenerated with `pip-compile --allow-unsafe --generate-hashes --upgrade`. `mkdocs-material` 9.7.7 declares `pymdown-extensions>=10.2` with no upper bound, so the 11.x major is in range for the theme — no theme pin change needed, and the docs site builds clean (evidence below). The `b64` extension that carries CVE-2026-61632 is not enabled in `docs/mkdocs.yml` at all; the bump closes the advisory rather than a live exposure. ## Not fixable — `GO-2026-5932` (`golang.org/x/crypto/openpgp`) > The `golang.org/x/crypto/openpgp` package is unmaintained, unsafe by design, and has known security issues. This is a permanent "this package should not be used" notice, not a patchable defect. In OSV it is `introduced: 0` with **no fix event**, so no version of `x/crypto` clears it — bumping to 0.54.0 (done here anyway, for hygiene) changes nothing. **Reachability:** 1. **Where in the tree** — `x/crypto` is a direct dependency, required for `chacha20poly1305` in `pkg/api/secrets/ciphers`. The advisory covers only `openpgp` and its six subpackages. 2. **Is it in the artifact** — no. `go list -deps ./... | grep x/crypto/openpgp` returns nothing, and Go's linker does not emit packages no import path reaches. The vulnerable code is not present in any binary this repo produces. 3. **Is the vulnerable code called** — no. `govulncheck -mode=source ./...` reports **0 reachable vulnerabilities**; this advisory lands in its "modules you require, but your code doesn't appear to call" bucket. 4. **What OpenPGP work actually runs** — `github.com/ProtonMail/go-crypto/openpgp`, which is the maintained fork the advisory text itself recommends as the replacement. 5. **What would change the answer** — any new import of `x/crypto/openpgp/*`. That would flip the VEX statement to `affected` and block the gate. Recorded as `status: not_affected`, `justification: vulnerable_code_not_present` in [`vex/openvex.json`](vex/openvex.json), mirrored into [`osv-scanner.toml`](osv-scanner.toml) — Scorecard's check has no VEX input, so the mirror is the only channel that reaches it. No `.trivyignore`, no `# nosec`, nothing hidden. ## Re-triage of existing suppressions Both entries that predate this PR were re-checked rather than carried forward: | Advisory | Was | Now | Why | |---|---|---|---| | GO-2022-0635 (aws-sdk-go v1 s3crypto) | `not_affected` + ignore | `fixed`, ignore removed | `github.com/aws/aws-sdk-go` (v1) is no longer in `go.mod` — the Pulumi upgrades dropped the last build-graph edge and Go module pruning removed it. `osv-scanner` reported the entry as an **unused ignore**. | | GO-2022-0646 (same subpackage) | `not_affected` + ignore | `fixed`, ignore removed | Same. | VEX statements are kept one release as an audit trail; the `osv-scanner.toml` entries are gone. ## Governance changes - **CODEOWNERS** — `/vex/` and `/osv-scanner.toml` are now named explicitly. A `not_affected` statement hides a real advisory from both the scanners and the Scorecard badge; that is the same class of change as touching a workflow, and it should not merge on a generic `*` match. - **`docs/DEPENDENCIES.md`** — documents (a) that `osv-scanner.toml` is a *derivative* mirror which may only carry an ID that already exists in VEX, and (b) that every SCA pass re-triages both files, with `unused ignores` as the removal signal. Previously the policy said suppressions live "never in a scanner-suppression file" while `osv-scanner.toml` existed; policy and practice now agree. - **`osv-scanner.toml`** — added a note that `reason` must stay a single-line TOML basic string. A newline in it makes osv-scanner discard the **entire** config (`strings cannot contain newlines`) and silently re-report every ignored advisory. Hit while writing this PR. ## CI ordering (`tools.go` pre-bake) `build-setup` runs `go get $(tools.go imports)` → `go mod download` → `go generate -tags tools` → `go mod tidy`. Because `go get` resolves tools to *latest* and `tidy` only runs afterwards, a tool minor landing between runs breaks `go generate` with `missing go.sum entry`. The post-`go get` state is pre-baked into this commit so CI's `go get` is a no-op: `go-jsonschema` 0.23.1 → 0.24.1, `go-internal` 1.14.1 → 1.15.0, `gofumpt` 0.10.0 → 0.11.0, `x/mod` 0.37.0 → 0.38.0, `x/net` 0.56.0 → 0.57.0, `x/tools` 0.47.0 → 0.48.0, `x/telemetry` bumped. ## Dependabot reconciliation Open alerts before this PR: 5 — `pymdown-extensions`, `setuptools`, `soupsieve` ×2, `grpc`. All 5 are closed by the bumps above; they auto-resolve once this lands on `main`. `click` (PYSEC-2026-2132) and `klauspost/compress` (GO-2026-5841) were **not** alerted by Dependabot but are flagged by OSV — fixed here too. Open Dependabot PRs: | PR | Disposition | |---|---| | #361 `soupsieve 2.8.3 → 2.8.4` | Superseded — this PR goes to 2.9.1. Dependabot closes it automatically when the manifest lands. | | #371, #352, #351, #334, #333, #326 | Untouched — `github-actions` / `docker` streams, unrelated to this PR. | No config change needed: `.github/dependabot.yml` already covers `gomod` (/), `pip` (/docs), `docker`, and `github-actions`. ## Evidence <details> <summary><code>osv-scanner scan source -r .</code> — before</summary> ``` click 8.1.8 [PyPI] -> PYSEC-2026-2132 pymdown-extensions 10.21.3 [PyPI] -> GHSA-9xwg-3r6f-jcx2 setuptools 82.0.1 [PyPI] -> PYSEC-2026-3447, GHSA-h35f-9h28-mq5c soupsieve 2.8.3 [PyPI] -> PYSEC-2026-3071, PYSEC-2026-3072, GHSA-2wc2-fm75-p42x, GHSA-836r-79rf-4m37 klauspost/compress 1.18.4 [Go] -> GO-2026-5841 golang.org/x/crypto 0.53.0 [Go] -> GO-2026-5932 google.golang.org/grpc 1.81.1 [Go] -> GO-2026-6061, GHSA-hrxh-6v49-42gf osv-scanner.toml has unused ignores: - GO-2022-0635 - GO-2022-0646 ``` </details> <details> <summary><code>osv-scanner scan source -r .</code> — after</summary> ``` Scanned docs/requirements.txt file and found 36 packages Scanned go.mod file and found 486 packages Loaded filter from: osv-scanner.toml GO-2026-5932 has been filtered out because: VEX not_affected (vulnerable_code_not_present) ... Filtered 1 vulnerability from output No issues found ``` </details> <details> <summary><code>govulncheck -mode=source ./...</code> — after</summary> ``` === Symbol Results === No vulnerabilities found. Your code is affected by 0 vulnerabilities. This scan also found 0 vulnerabilities in packages you import and 1 vulnerability in modules you require, but your code doesn't appear to call these vulnerabilities. ``` The 1 module-level finding is GO-2026-5932, covered above. </details> ## Test plan - [x] `go build ./...` - [x] `go generate -tags tools` (post-pre-bake, matches CI's build-setup order) - [x] `go test ./pkg/api/secrets/... ./pkg/security/... -count=1` — all pass - [x] Docs built exactly as CI does it: `docker run --rm -v $PWD/docs:/docs -w /docs python@sha256:401f6e1a... sh -c "pip install --require-hashes -r requirements.txt && mkdocs build"` → `Documentation built in 3.39 seconds`, hash check clean, no new warnings - [x] `jq empty vex/openvex.json` - [ ] CI: govulncheck, CodeQL, Semgrep, build matrix Signed-off-by: Dmitrii Creed <creeed22@gmail.com>
Contributor
Author
|
Dependabot tried to update this pull request, but something went wrong. We're looking into it, but in the meantime you can retry the update by commenting |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps the github-actions group with 8 updates in the / directory:
4.1.04.1.14.1.04.2.07.2.07.3.04.36.24.37.34.36.24.37.34.36.24.37.32.4.32.4.44.36.24.37.3Updates
actions/attest-build-provenancefrom 4.1.0 to 4.1.1Release notes
Sourced from actions/attest-build-provenance's releases.
Commits
0f67c3fBump actions/checkout from 6.0.3 to 7.0.0 (#857)21b787dUpdate actions/attest to v4.1.1 (#858)f14352aadd dependabot cooldown (#851)2c04a00Bump actions/checkout from 6.0.2 to 6.0.3 in the actions-minor group (#850)10334b5remove badges from README (#840)c5efebdremove prober workflows (#837)Updates
docker/setup-buildx-actionfrom 4.1.0 to 4.2.0Release notes
Sourced from docker/setup-buildx-action's releases.
Commits
bb05f3fMerge pull request #580 from docker/dependabot/npm_and_yarn/docker/actions-to...321c814[dependabot skip] chore: update generated contentb9a36efbuild(deps): bump@docker/actions-toolkitfrom 0.91.0 to 0.92.0ebeab24Merge pull request #570 from docker/dependabot/npm_and_yarn/undici-6.27.05c7b8ae[dependabot skip] chore: update generated content037e618build(deps): bump undici from 6.25.0 to 6.27.066080e5Merge pull request #577 from docker/dependabot/npm_and_yarn/sigstore-4.1.1409aef0Merge pull request #562 from docker/dependabot/npm_and_yarn/js-yaml-4.2.049c6e42build(deps): bump sigstore from 4.1.0 to 4.1.12211273[dependabot skip] chore: update generated contentUpdates
docker/build-push-actionfrom 7.2.0 to 7.3.0Release notes
Sourced from docker/build-push-action's releases.
Commits
53b7df9Merge pull request #1572 from docker/dependabot/npm_and_yarn/docker/actions-t...154298c[dependabot skip] chore: update generated contentcb1238bchore(deps): Bump@docker/actions-toolkitfrom 0.91.0 to 0.92.024f845dMerge pull request #1566 from docker/dependabot/npm_and_yarn/js-yaml-4.2.09c69730[dependabot skip] chore: update generated contentbc3a3a5Merge pull request #1574 from docker/dependabot/github_actions/aws-actions/co...a82c504chore(deps): Bump js-yaml from 4.1.1 to 4.3.00285a75Merge pull request #1573 from docker/dependabot/github_actions/actions/cache-...c6ad2a3Merge pull request #1575 from docker/dependabot/github_actions/actions/checko...d37484fMerge pull request #1564 from docker/dependabot/npm_and_yarn/undici-6.27.0Updates
github/codeql-action/initfrom 4.36.2 to 4.37.3Release notes
Sourced from github/codeql-action/init's releases.
Changelog
Sourced from github/codeql-action/init's changelog.
... (truncated)
Commits
e4fba86Merge pull request #4031 from github/update-v4.37.3-72f6a9da0fb50ab5Update changelog for v4.37.372f6a9dMerge pull request #4030 from github/mbg/fix/no-proxy3b5ee58Use defaultrequestoptions instead ofundefinedbfb6be4Merge pull request #4028 from github/mergeback/v4.37.2-to-main-e0647621526ab84Rebuildd6217b9Update changelog and version after v4.37.2e064762Merge pull request #4027 from github/update-v4.37.2-385bcdc5ae0faed8Add a couple of change notes73aad0eUpdate changelog for v4.37.2Updates
github/codeql-action/autobuildfrom 4.36.2 to 4.37.3Release notes
Sourced from github/codeql-action/autobuild's releases.
Changelog
Sourced from github/codeql-action/autobuild's changelog.
... (truncated)
Commits
e4fba86Merge pull request #4031 from github/update-v4.37.3-72f6a9da0fb50ab5Update changelog for v4.37.372f6a9dMerge pull request #4030 from github/mbg/fix/no-proxy3b5ee58Use defaultrequestoptions instead ofundefinedbfb6be4Merge pull request #4028 from github/mergeback/v4.37.2-to-main-e0647621526ab84Rebuildd6217b9Update changelog and version after v4.37.2e064762Merge pull request #4027 from github/update-v4.37.2-385bcdc5ae0faed8Add a couple of change notes73aad0eUpdate changelog for v4.37.2Updates
github/codeql-action/analyzefrom 4.36.2 to 4.37.3Release notes
Sourced from github/codeql-action/analyze's releases.
Changelog
Sourced from github/codeql-action/analyze's changelog.
... (truncated)
Commits
e4fba86Merge pull request #4031 from github/update-v4.37.3-72f6a9da0fb50ab5Update changelog for v4.37.372f6a9dMerge pull request #4030 from github/mbg/fix/no-proxy3b5ee58Use defaultrequestoptions instead ofundefinedbfb6be4Merge pull request #4028 from github/mergeback/v4.37.2-to-main-e0647621526ab84Rebuildd6217b9Update changelog and version after v4.37.2e064762Merge pull request #4027 from github/update-v4.37.2-385bcdc5ae0faed8Add a couple of change notes73aad0eUpdate changelog for v4.37.2Updates
ossf/scorecard-actionfrom 2.4.3 to 2.4.4Release notes
Sourced from ossf/scorecard-action's releases.
Commits
2d11466Bump action tag for v2.4.4 release (#1688)1bd3285🌱 Bump the docker-images group across 1 directory with 2 updates (#1...913edce🌱 Bump github.com/containerd/containerd from 1.7.32 to 1.7.33 (#1671)0957b8f🌱 Bump golang.org/x/net from 0.56.0 to 0.57.0 (#1680)f0061eb🌱 Bump google.golang.org/grpc from 1.81.1 to 1.82.1 (#1687)20ee732🌱 Bump github.com/sigstore/cosign/v2 from 2.6.3 to 2.6.4 (#1685)9f295ef🌱 Bump the github-actions group with 6 updates (#1686)69bf556🌱 Bump github.com/sigstore/sigstore-go from 1.1.4 to 1.2.0 (#1681)94e8b96🌱 Bump github.com/sigstore/rekor from 1.5.0 to 1.5.2 (#1673)c7a1b37🌱 Bump github.com/sigstore/fulcio from 1.8.5 to 1.8.6 (#1675)Updates
github/codeql-action/upload-sariffrom 4.36.2 to 4.37.3Release notes
Sourced from github/codeql-action/upload-sarif's releases.
Changelog
Sourced from github/codeql-action/upload-sarif's changelog.
... (truncated)
Commits
e4fba86Merge pull request #4031 from github/update-v4.37.3-72f6a9da0fb50ab5Update changelog for v4.37.372f6a9dMerge pull request #4030 from github/mbg/fix/no-proxy3b5ee58Use defaultrequestoptions instead ofundefinedbfb6be4Merge pull request #4028 from github/mergeback/v4.37.2-to-main-e0647621526ab84Rebuildd6217b9Update changelog and version after v4.37.2e064762Merge pull request #4027 from github/update-v4.37.2-385bcdc5ae0faed8Add a couple of change notes73aad0eUpdate changelog for v4.37.2Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore <dependency name> major versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)@dependabot ignore <dependency name> minor versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)@dependabot ignore <dependency name>will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)@dependabot unignore <dependency name>will remove all of the ignore conditions of the specified dependency@dependabot unignore <dependency name> <ignore condition>will remove the ignore condition of the specified dependency and ignore conditions