Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Fubo Icon (#10047) #10192

Merged
merged 3 commits into from
Jan 12, 2024
Merged

Add Fubo Icon (#10047) #10192

merged 3 commits into from
Jan 12, 2024

Conversation

andyrak
Copy link
Contributor

@andyrak andyrak commented Dec 29, 2023

image

Issue: closes #10047

Similarweb rank: 1,295

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

  • Hex value extracted from the official logo.
  • Vector extracted as AI from official brand assets.

@github-actions github-actions bot added the new icon Issues or pull requests for adding a new icon label Dec 29, 2023
adamrusted
adamrusted requested changes Dec 31, 2023
View reviewed changes
Copy link
Member

@adamrusted adamrusted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at the version available here in red, it would appear your PR is slightly stretched. Would you mind having another look please, @andyrak?

image

@PeterShaggyNoble
Copy link
Member

Are you still working on this one, @andyrak?

@andyrak
Copy link
Contributor Author

andyrak commented Jan 11, 2024

@PeterShaggyNoble Yes, will have some time today to investigate!

@andyrak
Copy link
Contributor Author

andyrak commented Jan 11, 2024

@adamrusted Not sure where the discrepancy is coming from. Every version I've checked matches my original outline, not the red as you highlighted. Unless I'm doing something terribly wrong in my workflow.

I confirmed this with these three files:

My original was lifted from the logo on the right-side margin of page 4 of the PDF listed above.

PeterShaggyNoble
PeterShaggyNoble approved these changes Jan 12, 2024
View reviewed changes
Copy link
Member

@PeterShaggyNoble PeterShaggyNoble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My original was lifted from the logo on the right-side margin of page 4 of the PDF listed above.

Compared against that logo, your version lines up perfectly 👍

For the colour, though, I'm getting #e03100 from the stylesheet on their login page and #c83d1e from other pages like this one. And of those 2, I'd lean towards the latter.

@andyrak
Copy link
Contributor Author

andyrak commented Jan 12, 2024

Thanks, @PeterShaggyNoble!

I've updated the json to reflect #C83D1E.

image

@PeterShaggyNoble PeterShaggyNoble merged commit 2d2b876 into simple-icons:develop Jan 12, 2024
3 checks passed
@PeterShaggyNoble
Copy link
Member

Thanks for your work on this, @andyrak 👍

@andyrak
Copy link
Contributor Author

andyrak commented Jan 12, 2024

Thanks for the help! Excited to make other contributions in the future. Have a good one!

@github-actions github-actions bot mentioned this pull request Jan 14, 2024
Merged
mondeja added a commit that referenced this pull request Jan 14, 2024
@mondeja
Release 20 new icons and 16 updated icons (v11.1.0)
aaf2f27 
# New Icons

- 7Zip (#7334)
- Asahi Linux (#10245)
- Babelio (#10232)
- Brenntag (#10215)
- Carlsberg Group (#8819)
- CNET (#10228)
- DaVinci Resolve (#9766)
- Edge Impulse (#10201)
- Esoteric Software (#10280)
- Fubo (#10192)
- Hyperskill (#10226)
- Knex.js (#10236)
- Linksys (#10231)
- Nomad (#9527)
- Orange (#10227)
- Paramount+ (#10248)
- Reactive Resume (#10225)
- Solana (#10246)
- Spine (#10239)
- TickTick (#10224)

# Updated Icons

- .ENV (#10255)
- .NET (#10255)
- /e/ (#10269)
- 1001Tracklists (#10260)
- 1Password (#10256)
- 42 (#10278)
- 500px (#10270)
- Aston Martin (#10253)
- Dailymotion (#10216)
- Duolingo (#10111)
- Instagram (#10153)
- LADA (#10155)
- Minecraft (#10242)
- Nintendo (#10263, #10266)
- Revolut (#10238)
- Zapier (#10265)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamrusted adamrusted adamrusted requested changes

@PeterShaggyNoble PeterShaggyNoble PeterShaggyNoble approved these changes

Assignees
No one assigned
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fubo
3 participants
@andyrak @PeterShaggyNoble @adamrusted