Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Asahi Linux #10245

Merged
merged 11 commits into from Jan 9, 2024
Merged

Asahi Linux #10245

merged 11 commits into from Jan 9, 2024

Conversation

durgeshgowdac
Copy link
Contributor

@durgeshgowdac durgeshgowdac commented Jan 9, 2024 •
edited

image

Issue: closes #10158

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

@github-actions github-actions bot added the new icon Issues or pull requests for adding a new icon label Jan 9, 2024
@durgeshgowdac
Update simple-icons.json
191eb9f 
Changed the order of the Asahi Linux Order
PeterShaggyNoble
PeterShaggyNoble requested changes Jan 9, 2024
View reviewed changes
Copy link
Member

@PeterShaggyNoble PeterShaggyNoble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution, @durgeshgowdac 👍🏻 However, I'm seeing some significant differences between your version (in red below) and the source file (in black) - would you mind having another go at this, please?

Also, for GitHub sources, we use the latest commit URL which, in this case, would be https://github.com/AsahiLinux/artwork/blob/292637c9658c1491ddc1128fb6134aec01d904dd/logos/svg/AsahiLinux_logomark_mono.svg

@durgeshgowdac
Copy link
Contributor Author

durgeshgowdac commented Jan 9, 2024 •
edited

@PeterShaggyNoble I've changed the source to https://github.com/AsahiLinux/artwork/blob/292637c9658c1491ddc1128fb6134aec01d904dd/logos/svg/AsahiLinux_logomark_mono.svg

Thank You,
@durgeshgowdac

@durgeshgowdac durgeshgowdac changed the title Asahilinux Asahi Linux Jan 9, 2024
@PeterShaggyNoble
Copy link
Member

Thanks, @durgeshgowdac. When you've updated the SVG then please re-request a review from me and I'll have a look over it.

PeterShaggyNoble
PeterShaggyNoble approved these changes Jan 9, 2024
View reviewed changes
Copy link
Member

@PeterShaggyNoble PeterShaggyNoble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SVG looks perfect now, @durgeshgowdac - nice work.

@PeterShaggyNoble PeterShaggyNoble merged commit b60bf61 into simple-icons:develop Jan 9, 2024
3 checks passed
@github-actions github-actions bot mentioned this pull request Jan 14, 2024
Merged
mondeja added a commit that referenced this pull request Jan 14, 2024
@mondeja
Release 20 new icons and 16 updated icons (v11.1.0)
aaf2f27 
# New Icons

- 7Zip (#7334)
- Asahi Linux (#10245)
- Babelio (#10232)
- Brenntag (#10215)
- Carlsberg Group (#8819)
- CNET (#10228)
- DaVinci Resolve (#9766)
- Edge Impulse (#10201)
- Esoteric Software (#10280)
- Fubo (#10192)
- Hyperskill (#10226)
- Knex.js (#10236)
- Linksys (#10231)
- Nomad (#9527)
- Orange (#10227)
- Paramount+ (#10248)
- Reactive Resume (#10225)
- Solana (#10246)
- Spine (#10239)
- TickTick (#10224)

# Updated Icons

- .ENV (#10255)
- .NET (#10255)
- /e/ (#10269)
- 1001Tracklists (#10260)
- 1Password (#10256)
- 42 (#10278)
- 500px (#10270)
- Aston Martin (#10253)
- Dailymotion (#10216)
- Duolingo (#10111)
- Instagram (#10153)
- LADA (#10155)
- Minecraft (#10242)
- Nintendo (#10263, #10266)
- Revolut (#10238)
- Zapier (#10265)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PeterShaggyNoble PeterShaggyNoble PeterShaggyNoble approved these changes

Assignees
No one assigned
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Request: Asahi Linux
2 participants
@durgeshgowdac @PeterShaggyNoble