-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hyperskill - new logo addition #10226
Conversation
changed “” to "".
|
Changed lowercase to uppercase in HEX |
ISSUE: #10182 Pull Request SummaryThis pull request adds Hyperskill Logo. Changes Made
Issues while commiting
Resolved Issues
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution, @durgeshgowdac 👍🏻 However, I'm seeing some significant differences between your version (in red) and the logo in their website's header. I notice, though, you based your version on a different file. Whereabouts on their site did you find that?
Also, for the colour, I think I'd expect a darker blue based on the website's colour scheme. Which one, I don't know, though. Perhaps #5d72e9
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your new SVG lines up perfectly with the source, @durgeshgowdac, nice work.
Before I merge, though, what do you think of my suggested change to the colour?
changed “” to "";
Changed lowercase to uppercase in HEX
@durgeshgowdac, where did you source that new colour from? I'm not seeing it in their website's stylesheet. |
Closes Issue #10182 Changes:
|
@PeterShaggyNoble I found an extension (site palette) which extracts color palette from the given website. It scanned the whole website and showed |
The problem is, though, @durgeshgowdac, that that colour doesn't appear in their CSS varaiables 🤔 |
@PeterShaggyNoble Can I change it to |
From the variable names above, @durgeshgowdac, it looks to me like that colour is no longer in use. |
@PeterShaggyNoble What about If you have any other color in mind. Let me Know |
👍🏻 That seems as good a choice as any to me; equally as valid as my suggestion. |
@PeterShaggyNoble I've made all the changes. You can merge now. Thank You, |
# New Icons - 7Zip (#7334) - Asahi Linux (#10245) - Babelio (#10232) - Brenntag (#10215) - Carlsberg Group (#8819) - CNET (#10228) - DaVinci Resolve (#9766) - Edge Impulse (#10201) - Esoteric Software (#10280) - Fubo (#10192) - Hyperskill (#10226) - Knex.js (#10236) - Linksys (#10231) - Nomad (#9527) - Orange (#10227) - Paramount+ (#10248) - Reactive Resume (#10225) - Solana (#10246) - Spine (#10239) - TickTick (#10224) # Updated Icons - .ENV (#10255) - .NET (#10255) - /e/ (#10269) - 1001Tracklists (#10260) - 1Password (#10256) - 42 (#10278) - 500px (#10270) - Aston Martin (#10253) - Dailymotion (#10216) - Duolingo (#10111) - Instagram (#10153) - LADA (#10155) - Minecraft (#10242) - Nintendo (#10263, #10266) - Revolut (#10238) - Zapier (#10265)
ISSUE: Closes #10182
Tasks Completed:
1. Added New Icon:
2. Updated JSON Data:
Additional Information:
Icon Details:
Testing:
Visual Inspection: