Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hyperskill - new logo addition #10226

Merged
merged 12 commits into from
Jan 8, 2024

Conversation

durgeshgowdac
Copy link
Contributor

@durgeshgowdac durgeshgowdac commented Jan 7, 2024

ISSUE: Closes #10182

Tasks Completed:

1. Added New Icon:

  • Added the hyperskill.svg icon to the simple-icons/icons directory.

2. Updated JSON Data:

  • Updated the JSON data in _data/simple-icons.json to include information about the new hyperskill icon.

Additional Information:

Icon Details:

  • The hyperskill.svg icon represents the Hyperskill brand.
  • The icon follows the standard format and guidelines used in Simple Icons.

Testing:

  • I have tested the icon locally to ensure it displays correctly.

Visual Inspection:

  • Visually inspected the icon to confirm that it aligns with the Simple Icons style and quality.

@github-actions github-actions bot added the new icon Issues or pull requests for adding a new icon label Jan 7, 2024
@durgeshgowdac
Copy link
Contributor Author

changed “” to "".

  • Encountered a quotation mark mismatch in the JSON file. It might be due to different encoding or formatting issues.

@durgeshgowdac
Copy link
Contributor Author

Changed lowercase to uppercase in HEX

@durgeshgowdac
Copy link
Contributor Author

durgeshgowdac commented Jan 7, 2024

ISSUE: #10182

Pull Request Summary

This pull request adds Hyperskill Logo.

Changes Made

  • Added the hyperskill.svg icon to the simple-icons/icons directory.
  • Updated the JSON data in _data/simple-icons.json to include information about the new hyperskill icon.

Issues while commiting

  • There was a quotaion mismatch due to different encoding or formatting issue in JSON file.
  • Had used lowercase for HEX.

Resolved Issues

  • Changed the quotaions to match the encodings.
  • Changed the lowercase HEX to Uppercase HEX.

@durgeshgowdac durgeshgowdac reopened this Jan 7, 2024
@durgeshgowdac durgeshgowdac mentioned this pull request Jan 7, 2024
Copy link
Member

@PeterShaggyNoble PeterShaggyNoble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution, @durgeshgowdac 👍🏻 However, I'm seeing some significant differences between your version (in red) and the logo in their website's header. I notice, though, you based your version on a different file. Whereabouts on their site did you find that?

Also, for the colour, I think I'd expect a darker blue based on the website's colour scheme. Which one, I don't know, though. Perhaps #5d72e9?

Copy link
Member

@PeterShaggyNoble PeterShaggyNoble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your new SVG lines up perfectly with the source, @durgeshgowdac, nice work.

Before I merge, though, what do you think of my suggested change to the colour?

@PeterShaggyNoble PeterShaggyNoble added the in discussion There is an ongoing discussion that should be finished before we can continue label Jan 8, 2024
@PeterShaggyNoble
Copy link
Member

@durgeshgowdac, where did you source that new colour from? I'm not seeing it in their website's stylesheet.

@durgeshgowdac
Copy link
Contributor Author

image

Closes Issue #10182

Changes:

  • Previously uploaded hyperskill.svg had scaling issue. I've resolved it and uploaded the new optimized hyperskill.svg
  • I think Cornflower Blue #6962F2 is a more dominant color. I've updated the Hex in simpleicons.json

@durgeshgowdac
Copy link
Contributor Author

durgeshgowdac commented Jan 8, 2024

@durgeshgowdac, where did you source that new colour from? I'm not seeing it in their website's stylesheet.

@PeterShaggyNoble I found an extension (site palette) which extracts color palette from the given website. It scanned the whole website and showed #6962F2 to be the most dominant color.

@PeterShaggyNoble
Copy link
Member

The problem is, though, @durgeshgowdac, that that colour doesn't appear in their CSS varaiables 🤔

@durgeshgowdac
Copy link
Contributor Author

@PeterShaggyNoble Can I change it to #6C63FF?

@PeterShaggyNoble
Copy link
Member

From the variable names above, @durgeshgowdac, it looks to me like that colour is no longer in use.

@durgeshgowdac
Copy link
Contributor Author

From the variable names above, @durgeshgowdac, it looks to me like that colour is no longer in use.

@PeterShaggyNoble What about #8C5AFF?

If you have any other color in mind. Let me Know

@PeterShaggyNoble
Copy link
Member

👍🏻 That seems as good a choice as any to me; equally as valid as my suggestion.

@durgeshgowdac
Copy link
Contributor Author

@PeterShaggyNoble I've made all the changes. You can merge now.

Thank You,
@durgeshgowdac

@PeterShaggyNoble PeterShaggyNoble merged commit 7d37758 into simple-icons:develop Jan 8, 2024
3 checks passed
@github-actions github-actions bot removed the in discussion There is an ongoing discussion that should be finished before we can continue label Jan 8, 2024
mondeja added a commit that referenced this pull request Jan 14, 2024
# New Icons

- 7Zip (#7334)
- Asahi Linux (#10245)
- Babelio (#10232)
- Brenntag (#10215)
- Carlsberg Group (#8819)
- CNET (#10228)
- DaVinci Resolve (#9766)
- Edge Impulse (#10201)
- Esoteric Software (#10280)
- Fubo (#10192)
- Hyperskill (#10226)
- Knex.js (#10236)
- Linksys (#10231)
- Nomad (#9527)
- Orange (#10227)
- Paramount+ (#10248)
- Reactive Resume (#10225)
- Solana (#10246)
- Spine (#10239)
- TickTick (#10224)

# Updated Icons

- .ENV (#10255)
- .NET (#10255)
- /e/ (#10269)
- 1001Tracklists (#10260)
- 1Password (#10256)
- 42 (#10278)
- 500px (#10270)
- Aston Martin (#10253)
- Dailymotion (#10216)
- Duolingo (#10111)
- Instagram (#10153)
- LADA (#10155)
- Minecraft (#10242)
- Nintendo (#10263, #10266)
- Revolut (#10238)
- Zapier (#10265)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hyperskill
2 participants