Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Carlsberg Group icon #8819

Merged
merged 14 commits into from
Jan 11, 2024

Conversation

blakmagjick
Copy link
Contributor

carlsberggroup

Issue: closes #8813

Similarweb rank: #495,776 Globally

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

@github-actions github-actions bot added the new icon Issues or pull requests for adding a new icon label Jun 16, 2023
@blakmagjick
Copy link
Contributor Author

This isn't passing all the checks, need to fiddle with the icon a bit more tonight.

@blakmagjick
Copy link
Contributor Author

Finally got the linter to work locally...so hopefully I can get this sorted without having to push so many updates🥲

@LitoMore
Copy link
Member

In their brand guideline, I didn't see a use case for the clover shape part. We may need to keep the complete trademark.

Or you can reach out to them through mail or their social media for approval.

@LitoMore LitoMore added the awaiting reply Issues or pull requests awaiting reply from an individual before it may be addressed label Jul 12, 2023
@blakmagjick
Copy link
Contributor Author

I've sent an email to contact@carlsberg.com this afternoon asking for approval/feedback. Will keep the thread posted when I hear something back.

@jcrqr
Copy link

jcrqr commented Jul 13, 2023

@blakmagjick If you don’t get a reply soon, ping me and I’ll try reaching out internally.

@blakmagjick
Copy link
Contributor Author

@blakmagjick If you don’t get a reply soon, ping me and I’ll try reaching out internally.

Thanks! If you could ping internally, that would likely be faster! 😸
I only got an auto reply to my email, and even that said there is no guarantee that there will be a reply.

@jcrqr
Copy link

jcrqr commented Jul 18, 2023

Will do that! No worries and thanks! ☺️

@service-paradis
Copy link
Member

@wtfiscrq Any news?

@adamrusted
Copy link
Member

adamrusted commented Dec 1, 2023

Given we've had no response, and although they include the logomark on their website, do not use it apart from the full wordmark elsewhere - I'm going to close this one down for now. If you want to re-work this to include the full wordmark @blakmagjick - be my guest and we can re-open this PR!

Edit: Scrap that. They provide official brand guidelines, and explicitly only use the full wordmark. @blakmagjick - could you re-work this PR to use that?

@adamrusted adamrusted closed this Dec 1, 2023
@adamrusted adamrusted reopened this Dec 1, 2023
@adamrusted adamrusted added changes requested and removed awaiting reply Issues or pull requests awaiting reply from an individual before it may be addressed labels Dec 1, 2023
Copy link
Member

@adamrusted adamrusted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@blakmagjick
Copy link
Contributor Author

I can definitely take a stab at it, but due to my current work schedule and moving at the end of the month, I won't be able to tackle it until after the new year....but since this has been open since July, I'm gonna guess that won't be a problem...lol

@adamrusted
Copy link
Member

Nah, no rush! If (like now) the branch gets conflicts with our main branch, one of us will likely resolve the conflicts - but otherwise just as/when you can get to it. If timelines look unreasonable or you don't fancy carrying on then feel free to close at any point, and someone else can start from the issue :)

@PeterShaggyNoble PeterShaggyNoble marked this pull request as draft December 8, 2023 15:55
@PeterShaggyNoble PeterShaggyNoble self-assigned this Jan 11, 2024
@PeterShaggyNoble
Copy link
Member

PeterShaggyNoble commented Jan 11, 2024

@blakmagjick, I hope you don't mind but, in the interest of moving it along, I've pushed a few updates to this PR - I'm on a bit of a rampage at the moment, trying to clear out as many issues and PRs as I can!

My icon is based on \Carlsberg_Group\ai_Professional_use\RGB\Carlsberg_Group_Carlsberg_green_RGB.ai from the zip file available at the source URL.

Carlsberg Group

@PeterShaggyNoble PeterShaggyNoble marked this pull request as ready for review January 11, 2024 11:44
Copy link
Member

@adamrusted adamrusted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adamrusted adamrusted merged commit 5d28531 into simple-icons:develop Jan 11, 2024
3 checks passed
mondeja added a commit that referenced this pull request Jan 14, 2024
# New Icons

- 7Zip (#7334)
- Asahi Linux (#10245)
- Babelio (#10232)
- Brenntag (#10215)
- Carlsberg Group (#8819)
- CNET (#10228)
- DaVinci Resolve (#9766)
- Edge Impulse (#10201)
- Esoteric Software (#10280)
- Fubo (#10192)
- Hyperskill (#10226)
- Knex.js (#10236)
- Linksys (#10231)
- Nomad (#9527)
- Orange (#10227)
- Paramount+ (#10248)
- Reactive Resume (#10225)
- Solana (#10246)
- Spine (#10239)
- TickTick (#10224)

# Updated Icons

- .ENV (#10255)
- .NET (#10255)
- /e/ (#10269)
- 1001Tracklists (#10260)
- 1Password (#10256)
- 42 (#10278)
- 500px (#10270)
- Aston Martin (#10253)
- Dailymotion (#10216)
- Duolingo (#10111)
- Instagram (#10153)
- LADA (#10155)
- Minecraft (#10242)
- Nintendo (#10263, #10266)
- Revolut (#10238)
- Zapier (#10265)
@blakmagjick
Copy link
Contributor Author

Didn't mind at all...I started a new job and this kept being pushed to the back burner for me. (Like, three weeks later I'm finally commenting...heh) Thanks for getting it over the finish line!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Carlsberg Group logo
6 participants