Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Dailymotion #10216

Merged
merged 4 commits into from
Jan 8, 2024
Merged

Conversation

Mvlprem
Copy link
Member

@Mvlprem Mvlprem commented Jan 6, 2024

dailymotion

Issue: #10073

Similarweb rank: 351

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

svg taken from their careers page which is being used as a bg img look at this screenshot, Hex taken from stylesheet #0A0A0A

@github-actions github-actions bot added the update icon/data Issues or pull requests regarding icons that are outdated, this can be the SVG or color or both label Jan 6, 2024
Copy link
Member

@PeterShaggyNoble PeterShaggyNoble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incredible find, @Mvlprem! 😁

There are, though, a few excess points in the original which you might be able to remove in your version. Would you mind having a look at that?

Also, from the website's stylesheet, it looks like the colour has been changed slightly so we should update that here too.

_data/simple-icons.json Outdated Show resolved Hide resolved
@PeterShaggyNoble
Copy link
Member

I'm still seeing those excess points, @Mvlprem; there are 2 clusters in the bottom left and one pair of overlapping points in the upper left.

@Mvlprem
Copy link
Member Author

Mvlprem commented Jan 8, 2024

I'm still seeing those excess points, @Mvlprem; there are 2 clusters in the bottom left and one pair of overlapping points in the upper left.

@PeterShaggyNoble can you provide a screenshot, i didn't quite get you. Sorry for the extra work

@PeterShaggyNoble
Copy link
Member

@Mvlprem, see the circled points here.

@Mvlprem
Copy link
Member Author

Mvlprem commented Jan 8, 2024

@Mvlprem, see the circled points here.

@PeterShaggyNoble Fixed

@PeterShaggyNoble PeterShaggyNoble merged commit 04af163 into simple-icons:develop Jan 8, 2024
3 checks passed
@Mvlprem Mvlprem deleted the Update-Dailymotion branch January 9, 2024 06:13
mondeja added a commit that referenced this pull request Jan 14, 2024
# New Icons

- 7Zip (#7334)
- Asahi Linux (#10245)
- Babelio (#10232)
- Brenntag (#10215)
- Carlsberg Group (#8819)
- CNET (#10228)
- DaVinci Resolve (#9766)
- Edge Impulse (#10201)
- Esoteric Software (#10280)
- Fubo (#10192)
- Hyperskill (#10226)
- Knex.js (#10236)
- Linksys (#10231)
- Nomad (#9527)
- Orange (#10227)
- Paramount+ (#10248)
- Reactive Resume (#10225)
- Solana (#10246)
- Spine (#10239)
- TickTick (#10224)

# Updated Icons

- .ENV (#10255)
- .NET (#10255)
- /e/ (#10269)
- 1001Tracklists (#10260)
- 1Password (#10256)
- 42 (#10278)
- 500px (#10270)
- Aston Martin (#10253)
- Dailymotion (#10216)
- Duolingo (#10111)
- Instagram (#10153)
- LADA (#10155)
- Minecraft (#10242)
- Nintendo (#10263, #10266)
- Revolut (#10238)
- Zapier (#10265)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
update icon/data Issues or pull requests regarding icons that are outdated, this can be the SVG or color or both
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants