Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add 7Zip icon #7334

Merged
merged 5 commits into from
Jan 9, 2024
Merged

Add 7Zip icon #7334

merged 5 commits into from
Jan 9, 2024

Conversation

zrfisaac
Copy link
Contributor

@zrfisaac zrfisaac commented Apr 16, 2022 •
edited by service-paradis
Loading

7zip

Issue: Close #5872

Similarweb rank: 27,788

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

7-Zip is a file archiver with a high compression ratio.

@github-actions github-actions bot added the new icon Issues or pull requests for adding a new icon label Apr 16, 2022
@zrfisaac zrfisaac mentioned this pull request Apr 16, 2022
Closed
sisp
sisp reviewed Apr 21, 2022
View reviewed changes
Copy link
Contributor

@sisp sisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please clarify how you obtained the SVG icon? I can't find any icon on the download page you referenced, and the icon on the top-left of the website is a PNG image. Did you vectorize the icon yourself? In that case, I'd say the source URL should be the home page and not the downloads page. Or did you find an SVG icon somewhere else?

It would be great if the description section of the PR contained this kind of information when it is not obvious. See the PR template hint for that section:

Anything relevant, for example:

  • Why did you pick the hex value?
  • Did you manually vectorize the logo?
  • Have you used multiple sources?
  • etc.

@sachinraja
Copy link
Contributor

Yes, we do need more info on how you obtained the SVG icon (for your other PRs too)

@zrfisaac
Copy link
Contributor Author

Year I didn't find the icon either, there is no SVG official file, so I made one by myself.
Now I have a question, can I do that?
Or must exist an official publication of the SVG file?

@zrfisaac zrfisaac mentioned this pull request Apr 24, 2022
Closed
@zrfisaac
Copy link
Contributor Author

I've created An issue in the official 7zip github repository to upload the SVG file with the logo.
You can see in 7zip page that this repository is official :
image
Or you need that this SVG file must be uploaded in Source Forge repository ?

@zrfisaac zrfisaac mentioned this pull request Apr 24, 2022
Merged
3 tasks
@sachinraja
Copy link
Contributor

I think we can use Source Forge as a source so that could work

@zrfisaac
Copy link
Contributor Author

I asked them, but apparently they don't have a svg file.
I’m working with that.
After they publish one I will ask you to merge.

Wait a while until I get it done.
🙌

@antermin
Copy link

jinfeihan57's repo isn't really official - being mentioned in the official 7-Zip website does not make it official, and it is actually a fork of p7zip, while p7zip is a port of 7-Zip to POSIX systems.

The official repo should be the one on SourceForge by Igor Pavlov.

Igor Pavlov created 7-Zip but it was Windows-only, so someone ported 7-Zip to POSIX systems (Linux, macOS, etc.) as p7zip.

However, p7zip is abandoned for several years already (no updates since 2016), so jinfeihan57 started a new fork. A few Linux distros (e.g. Arch Linux) switched to jinfeihan57's fork.

As Igor Pavlov has recently added official Linux/BSD/macOS support in 7-Zip, openSUSE Tumbleweed dropped p7zip and switched to upstream 7-Zip 21.07, and Debian, FreeBSD, etc. are now offering 7-Zip 21.07.

@zrfisaac
Copy link
Contributor Author

Okey, I'm working on updating the official repository with this svg file, I will inform you when it is done.

authifyAlly added a commit to authifyWeb/logos that referenced this pull request Mar 19, 2023
@authifyAlly
Add 7zip.org
da290fc 
Website: https://7-zip.org/
Image downloaded from : simple-icons/simple-icons#7334
@authifyAlly authifyAlly mentioned this pull request Mar 19, 2023
Merged
@adamrusted
Copy link
Member

Hey @zrfisaac - any joy getting an official SVG hosted for 7Zip?
No stress if not - just running through older PRs!

@zrfisaac
Copy link
Contributor Author

Hey @zrfisaac - any joy getting an official SVG hosted for 7Zip? No stress if not - just running through older PRs!

I've been off these days due to my job, but I'm back now. I will work on this and answer you as soon as possible! 🙌

@adamrusted adamrusted added the vector unavailable Issues and Pull Requests where no official SVG is available. label Jul 18, 2023
@PratyushJayachandran PratyushJayachandran added the awaiting reply Issues or pull requests awaiting reply from an individual before it may be addressed label Sep 14, 2023
@PeterShaggyNoble
Copy link
Member

Any update on this, @zrfisaac? If not then I think we should just proceed with reviewing this PR as-is.

PeterShaggyNoble
PeterShaggyNoble requested changes Dec 7, 2023
View reviewed changes
Copy link
Member

@PeterShaggyNoble PeterShaggyNoble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind having another look at this, please, @zrfisaac? In the absence of anything better to go on, we'll have to run with their primary logo and I'm seeing major differences in your version , in red.

There's actually an SVG on Wikimedia that might provide a better starting point.

@PeterShaggyNoble PeterShaggyNoble removed awaiting reply Issues or pull requests awaiting reply from an individual before it may be addressed vector unavailable Issues and Pull Requests where no official SVG is available. labels Dec 7, 2023
@PeterShaggyNoble PeterShaggyNoble self-assigned this Dec 14, 2023
PeterShaggyNoble
PeterShaggyNoble previously requested changes Dec 14, 2023
View reviewed changes
_data/simple-icons.json Outdated Show resolved Hide resolved
icons/7zip.svg Outdated Show resolved Hide resolved
@adamrusted adamrusted removed the request for review from sisp January 9, 2024 09:30
@adamrusted adamrusted merged commit 76dd1de into simple-icons:develop Jan 9, 2024
3 checks passed
@PeterShaggyNoble PeterShaggyNoble mentioned this pull request Jan 10, 2024
Closed
@github-actions github-actions bot mentioned this pull request Jan 14, 2024
Merged
mondeja added a commit that referenced this pull request Jan 14, 2024
@mondeja
Release 20 new icons and 16 updated icons (v11.1.0)
aaf2f27 
# New Icons

- 7Zip (#7334)
- Asahi Linux (#10245)
- Babelio (#10232)
- Brenntag (#10215)
- Carlsberg Group (#8819)
- CNET (#10228)
- DaVinci Resolve (#9766)
- Edge Impulse (#10201)
- Esoteric Software (#10280)
- Fubo (#10192)
- Hyperskill (#10226)
- Knex.js (#10236)
- Linksys (#10231)
- Nomad (#9527)
- Orange (#10227)
- Paramount+ (#10248)
- Reactive Resume (#10225)
- Solana (#10246)
- Spine (#10239)
- TickTick (#10224)

# Updated Icons

- .ENV (#10255)
- .NET (#10255)
- /e/ (#10269)
- 1001Tracklists (#10260)
- 1Password (#10256)
- 42 (#10278)
- 500px (#10270)
- Aston Martin (#10253)
- Dailymotion (#10216)
- Duolingo (#10111)
- Instagram (#10153)
- LADA (#10155)
- Minecraft (#10242)
- Nintendo (#10263, #10266)
- Revolut (#10238)
- Zapier (#10265)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sisp sisp sisp left review comments

@adamrusted adamrusted adamrusted approved these changes

@PeterShaggyNoble PeterShaggyNoble PeterShaggyNoble left review comments

Assignees

@PeterShaggyNoble PeterShaggyNoble

Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

7-Zip
7 participants
@zrfisaac @sachinraja @antermin @adamrusted @PeterShaggyNoble @sisp @PratyushJayachandran