Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Icon: DaVinci Resolve #9766

Merged
merged 9 commits into from Jan 12, 2024

Conversation

CodedFlute
Copy link
Contributor

@CodedFlute CodedFlute commented Oct 20, 2023

simpleicons

Issue: closes #6062

Similarweb rank: 18,374 (https://www.similarweb.com/website/blackmagicdesign.com/#overview)

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

Converted from .tif image. Used image trace for inside, manual shape creation for outside circle.
Interpreted colour as foreground, can be changed if desired.
Color code taken from #8288

@github-actions github-actions bot added the new icon Issues or pull requests for adding a new icon label Oct 20, 2023
@PratyushJayachandran PratyushJayachandran added the vector unavailable Issues and Pull Requests where no official SVG is available. label Nov 22, 2023
@PeterShaggyNoble
Copy link
Member

Thanks for your work on this, @CodedFlute 👍🏻

However, we will first need determine the popularity of this brand, as the Similarweb ranking is not an accurate reflection of it. Is there a Google Trends comparison that can be done with a similar brand that is either already in our collection or meets our ranking requirements, or is there some other metric we can use to gauge the popularity?

@PeterShaggyNoble PeterShaggyNoble added the in discussion There is an ongoing discussion that should be finished before we can continue label Nov 22, 2023
@CodedFlute
Copy link
Contributor Author

CodedFlute commented Nov 22, 2023

@PeterShaggyNoble Yes, it is most comparable to Adobe premier pro which is alread in this collection. I have linked a Google trends comparison between DaVinci resolve and Adobe Premier Pro, for context I also included Shotcut another video editing software that is also included in this collection

https://trends.google.ca/trends/explore?date=today%205-y&q=%2Fg%2F1q5y_dyrm,%2Fm%2F043dqq,%2Fm%2F012vyjlr&hl=en-CA

@PeterShaggyNoble PeterShaggyNoble added assessing Issues or icons that require manual input from a project maintainer before work can begin and removed in discussion There is an ongoing discussion that should be finished before we can continue labels Dec 7, 2023
@PeterShaggyNoble
Copy link
Member

I was going to say that it outperforming Shotcut was a good enough indication of its popularity but, after checking its rank, Shotcut is now way outside our scope. And DaVinci sitting in the midpoint between it and Premiere Pro isn't quite convincing enough in itself.

Is there anything, maybe, in #9979 that could help indicate its popularity?

@CodedFlute
Copy link
Contributor Author

It is also comparable to apple Final Cut Pro or iMovie, although neither of those are included in this collection there are open issues to add both. The linked Google trends also includes the generic video editing software topic as a comparison along with both iMovie and Final Cut Pro.
https://trends.google.ca/trends/explore?date=today%205-y&q=%2Fg%2F1q5y_dyrm,%2Fm%2F043dqq,Final%20Cut%20Pro,%2Fm%2F01qbx1,%2Fm%2F07_s4&hl=en-CA

@PeterShaggyNoble
Copy link
Member

Thanks, @CodedFlute 👍🏻 I think that it is currently trending better than iMovie is a good indication of its popularity; would any of the other @simple-icons/maintainers agree?

@runxel
Copy link
Member

runxel commented Dec 7, 2023

No objection here. DaVinci is the (un)sung hero of movie editing. Pretty safe to say it fulfills our metrics.

@PeterShaggyNoble PeterShaggyNoble removed the assessing Issues or icons that require manual input from a project maintainer before work can begin label Dec 8, 2023
@PeterShaggyNoble
Copy link
Member

Right, now that's out of the way (thanks for your patience, @CodedFlute), we can start the review process!

It looks to me like the icon they provide at the source might actually be outdated. Scrolling down through their product page I see that they consistently use a square version rather than a circle and their Wikipedia entry also uses the square version, which is a good quality PNG. Being more familiar with the brand (cc: @runxel), and to hopefully avoid having to start from scratch on this one, do they use the 2 versions interchangeably at all, or should we be using the square version?

@PeterShaggyNoble PeterShaggyNoble added the in discussion There is an ongoing discussion that should be finished before we can continue label Dec 8, 2023
@CodedFlute
Copy link
Contributor Author

I think you are be right. Looking at their media kit they provide both logos with no indication on which one is more current. Looking at current logo usage it appears that the square one is currently more used and the round one was used for the previous software version. I will get started on updating it to the square logo soon.

Updated Davinci Resolve logo to one with a square border
@CodedFlute
Copy link
Contributor Author

davinciresolve
Updated the logo to the version with the square boarder. Let me know if there are any more changes that need to be made.

Copy link
Member

@PeterShaggyNoble PeterShaggyNoble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating, @CodedFlute. Looking at the TIFF file in the zip file, though, this version should be a perfect square. Also, I don't know where the colour choice in the original PR came from but, lacking anything else more concrete to go on, what do you think of using the #233a51 from the source file?

@PeterShaggyNoble PeterShaggyNoble removed the in discussion There is an ongoing discussion that should be finished before we can continue label Jan 11, 2024
@PeterShaggyNoble
Copy link
Member

Are you still working on this one, @CodedFlute?

@CodedFlute
Copy link
Contributor Author

davinciresolve
Made it square and updated the colour. Let me know if there are any more changes i should make.

Copy link
Member

@PeterShaggyNoble PeterShaggyNoble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as manual vertorisations go, the SVG looks good to me now - nice work 🙂

As it is manually vectorised, though, we'll need the approval of one of the other @simple-icons/maintainers before merging. And I'd also like some input from them on the colour.

Copy link
Member

@service-paradis service-paradis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good enough, good job 🎉

@service-paradis service-paradis merged commit beb0029 into simple-icons:develop Jan 12, 2024
3 checks passed
mondeja added a commit that referenced this pull request Jan 14, 2024
# New Icons

- 7Zip (#7334)
- Asahi Linux (#10245)
- Babelio (#10232)
- Brenntag (#10215)
- Carlsberg Group (#8819)
- CNET (#10228)
- DaVinci Resolve (#9766)
- Edge Impulse (#10201)
- Esoteric Software (#10280)
- Fubo (#10192)
- Hyperskill (#10226)
- Knex.js (#10236)
- Linksys (#10231)
- Nomad (#9527)
- Orange (#10227)
- Paramount+ (#10248)
- Reactive Resume (#10225)
- Solana (#10246)
- Spine (#10239)
- TickTick (#10224)

# Updated Icons

- .ENV (#10255)
- .NET (#10255)
- /e/ (#10269)
- 1001Tracklists (#10260)
- 1Password (#10256)
- 42 (#10278)
- 500px (#10270)
- Aston Martin (#10253)
- Dailymotion (#10216)
- Duolingo (#10111)
- Instagram (#10153)
- LADA (#10155)
- Minecraft (#10242)
- Nintendo (#10263, #10266)
- Revolut (#10238)
- Zapier (#10265)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new icon Issues or pull requests for adding a new icon vector unavailable Issues and Pull Requests where no official SVG is available.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DaVinci Resolve Logo
5 participants