swap the call for the changes() method - #6
Merged
Conversation
Contributor
Author
There was a problem hiding this comment.
the eof was changed by github, sorry
Contributor
|
Small performance improvements like this will go a long way! Thanks for the heads up. Merging now. |
johnbarrierwilson
added a commit
that referenced
this pull request
Sep 5, 2013
swap the call for the changes() method
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this swap of lines is to make the call of the changes() a little bit more robust. Imagine a remote possibility of the window element being resized while the plugin is initialising, this will make a call of the changes() method because of the resize event (if this one happens after registering the listener) and another call of changes() that can't be omitted because it will always be called on initialise.
However making this modification the changes() method will be called first, but if the resized stops before registering the listener, the second call will not happen.