Skip to content

refactor/soap-ssl-validator-openssl#414

Merged
tvdijen merged 5 commits into
simplesamlphp:release-7.xfrom
ioigoume:refactor/soap-ssl-validator-openssl
Jul 5, 2026
Merged

refactor/soap-ssl-validator-openssl#414
tvdijen merged 5 commits into
simplesamlphp:release-7.xfrom
ioigoume:refactor/soap-ssl-validator-openssl

Conversation

@ioigoume

@ioigoume ioigoume commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

Remove xmlseclibs coupling by switching SOAP/Artifact validators to OpenSSL-based key extraction and updating tests

…penSSL-based key extraction and updating tests
@ioigoume ioigoume force-pushed the refactor/soap-ssl-validator-openssl branch from c0f7417 to 8470675 Compare July 1, 2026 09:29
@ioigoume ioigoume closed this Jul 1, 2026
@tvdijen

tvdijen commented Jul 1, 2026

Copy link
Copy Markdown
Member

Thank you so much @ioigoume !

@tvdijen tvdijen reopened this Jul 1, 2026
@ioigoume ioigoume requested a review from tvdijen July 1, 2026 09:41
Comment thread src/Binding/HTTPArtifact.php Outdated
@tvdijen tvdijen merged commit c6fea42 into simplesamlphp:release-7.x Jul 5, 2026
10 of 13 checks passed
tvdijen added a commit that referenced this pull request Jul 5, 2026
* Remove xmlseclibs coupling by switching SOAP/Artifact validators to OpenSSL-based key extraction and updating tests

* Refactor signature verification to fail fast by removing redundant algorithm type guard

* Remove string-casts

* Fix syntax

---------

Co-authored-by: Tim van Dijen <tvdijen@gmail.com>
@ioigoume ioigoume deleted the refactor/soap-ssl-validator-openssl branch July 6, 2026 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants