implement configurable prices for oracle - #28
Open
brenzi wants to merge 3 commits into
Open
Conversation
brenzi
marked this pull request as draft
August 31, 2026 13:30
epoberezkin
reviewed
Sep 3, 2026
| // The real `.simplex` curve, in attoUSD per second: $1/yr at 5+ characters, | ||
| // $32 at 4, $128 at 3. With the feed pinned to 1e8 below, 1 attoUSD is 1 wei, | ||
| // so a one-year 6-character name costs ~0.9993 ETH in these tests. | ||
| // $10/yr at 6+ characters, ten times more for each character lost. With the |
Author
There was a problem hiding this comment.
we need a nonzero default. what would you propose instead? We can override it anyway
brenzi
marked this pull request as ready for review
September 4, 2026 09:30
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #27.
Adds
SimplexPriceOracle, anIPriceOracleUSDimplementation whose price list lives in storage instead of in immutables, so changing what a name costs is an owner call rather than a redeploy plussetPriceOracle.Base $1/yr, rungs at 13 and 32:
storage after the call:
topRung = 32, lengths 1..13 hold4e18,lengths 14..32 hold
2e18,basePriceUSDPerYear = 1e18.And for the duch auction:
setPremium(startPremium, totalDays)retunes the Dutch auction on lapsed names.