Look for available subsystem on node from all online lvols - #1082
Merged
Conversation
…tover subsystems.
…mespace handling 2
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
schmidt-scaled
added a commit
that referenced
this pull request
Jun 8, 2026
…real bug) The Unit-tests CI job on main had been red for 25+ runs (a prior commit explicitly "cleared pre-existing linter/typecheck/cli-regen failures" but left unit tests broken). 44 tests across 15 files were failing. 43 were stale tests that lagged behind intentional production refactors (e.g. _request -> _request2 tuple API, get_mini_lvols() subsystem counting per #1082, lvs_node plumbing, caused_by="restart_cleanup" tagging, NQN format validation, pool-level DHCHAP key injection per #1074, 2s->1s drain window per #1078, source-shape anchor for the port-allow strict gate). These are fixed test-side to match current intended behavior, preserving each test's original intent. 1 was a genuine production bug: RPCClient.nvmf_subsystem_add_ns2 returned a bare int from its idempotent short-circuit, but the nvmf_subsystem_add_ns wrapper unpacks a (result, error) tuple -> TypeError on every idempotent no-op (the exact cluster_activate re-entry the feature targets). Fixed to return (existing_nsid, None). Full suite now green: 1262 passed, 257 skipped, 0 failed. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.