add: ClusterConfig for managing cluster-wide settings and enhance cluster creation logic - #1182
Merged
Conversation
…luster creation logic Fixes sfam-2790
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>
wmousa
added a commit
that referenced
this pull request
Jul 24, 2026
… k8s PR #1182 replaced add_cluster()'s inline "first cluster on kubernetes" setup (FDB connection string, grafana settings, mgmt-node registration) with an unconditional read of DeployConfig, but nothing writes that record for kubernetes deployments � only the docker-swarm create_cluster() path does. Every fresh k8s deployment's first cluster create therefore failed with KeyError: No deploy config found. Restore the bootstrap: when no clusters exist yet, derive mode/db connection/grafana settings, register the mgmt node, and persist the result as the DeployConfig subsequent add_cluster() calls read. Update tests/integration/test_cluster_duplicate_name.py, which seeded clusters without a DeployConfig (broken by #1182 independent of this fix), and add coverage for the restored bootstrap path.
wmousa
added a commit
that referenced
this pull request
Jul 24, 2026
… k8s PR #1182 replaced add_cluster()'s inline "first cluster on kubernetes" setup (FDB connection string, grafana settings, mgmt-node registration) with an unconditional read of DeployConfig, but nothing writes that record for kubernetes deployments � only the docker-swarm create_cluster() path does. Every fresh k8s deployment's first cluster create therefore failed with KeyError: No deploy config found. Restore the bootstrap: when no clusters exist yet, derive mode/db connection/grafana settings, register the mgmt node, and persist the result as the DeployConfig subsequent add_cluster() calls read. Update tests/integration/test_cluster_duplicate_name.py, which seeded clusters without a DeployConfig (broken by #1182 independent of this fix), and add coverage for the restored bootstrap path.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes sfam-2790