reworked cleanup implementation for lvol migration - #1201
Merged
Conversation
EbiRider
marked this pull request as ready for review
July 31, 2026 12:04
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
due to recent changes on postponing data migration if lvol migration is in process cleanup logic needed to be reworked practically when it should be fired
once the invovled nodes gets down for any reason the cleanup logic should fire immediately and the migration be marked as FAILED this is important as to not stall any pending data migration, this comes at the cost of lvol migration ability to recover after crashes since migration isn't allowed to get suspended and starving both the data migration and other lvol migrations waiting for the pending data migration to finish instead the lvol migration needs to be attempted again later by the user or the operator
so now at first failure migration is cleaned up and declared as FAILED
the other fail cases will still consume retry budgets up MAX_RETRIES