feat: reflect effective failure domain in StorageNode and StorageNode… - #385
Merged
Conversation
boddumanohar
approved these changes
Jul 31, 2026
mxsrc
approved these changes
Jul 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…Set status
Fixes: issue-386
Add failure domain to StorageNode and StorageNodeSet status
Reflects the failure domain of each storage node into the CR status fields,
making it observable withou t inspecting the spec or the backend directly.
Changes
failureDomainfield toStorageNodeStatusandNodeStatus(inStorageNodeSet.status.nodes[])FDprint column toStorageNode(kubectl get sn -o wide)failure_domaintoSNODEAPIResponse— sourced directly from the backend API (StorageNodeDTO.failure_domain)fdPtr()helper converts the API integer to*int32(nil when 0/unset)syncStatusandpollUUIDFromBackendsetstatus.failureDomainfrom the API response on every status patchsyncUUIDFromNodeSetcarries the value forward fromStorageNodeSet.status.nodes[]NodeStatus{}constructions in the SNS controller (onAllSocketNodesOnlineandsyncTrackedNodesStatus) populatefailureDomainfrom the API responseResult