fix(naming): client-side unique duplicate names for blocks

[waleedlatif1]

Summary

Implements client-side unique name generation for duplicated blocks, standardizing to " N" and preventing normalized collisions within a workflow. This keeps resolver/store normalization rules in sync and avoids server-side changes.

Why

• Avoids confusing name collisions after duplicate, especially across variants that normalize equal (e.g., "My Agent" vs "myagent").
• Ensures consistent UX across both duplicate entry points (collaborative and local store) with a single source of truth.
• Honors product decision to rely on client-side uniqueness only; server behavior unchanged.

Changes

• Added helper at apps/sim/lib/naming.ts:
  • normalizeBlockName(name) – lowercase + strip spaces (parity with resolver/store).
  • generateUniqueBlockDuplicateName(existingNames, sourceName) – produces "Base N"; starts at suffix+1 when source ends with whitespace+digits, otherwise 1; loops until normalized-unique.
• hooks/use-collaborative-workflow.ts → collaborativeDuplicateBlock now uses the helper with current workflow block names.
• stores/workflows/workflow/store.ts → duplicateBlock now uses the helper.
• updateBlockName in store now imports the shared normalizeBlockName to avoid drift.
• Tests: apps/sim/lib/naming.test.ts covering base/suffix cases, normalization collisions, gaps, whitespace-heavy names, mixed case, and empty names.

Impact

• Client-only change; server endpoints and duplication behavior remain unchanged.
• Rename validation continues to prevent normalized collisions; no regressions expected.

QA

• Create blocks: "Agent", "Agent 1". Duplicate "Agent" → expect "Agent 2".
• Create "Agent 3". Duplicate "Agent 2" → expect "Agent 4".
• Create "agent1" (if allowed). Duplicate "Agent" → should skip to next free beyond normalized collisions.
• Names with multiple spaces: "My Agent" duplicates to "My Agent 1"; if a normalized collision exists, increments accordingly.

Notes

• No server behavior changed; resolver normalization remains the source of truth we mirrored.
• Keeps naming behavior consistent whether duplication originates locally or via collaboration.

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Preview	Comments	Updated (UTC)
sim	Ready	Preview	Comment	Sep 6, 2025 6:49pm

1 Skipped Deployment

Project	Deployment	Preview	Comments	Updated (UTC)
docs	Skipped			Sep 6, 2025 6:49pm

[greptile-apps]

Greptile Summary

This PR implements a centralized client-side unique naming system for duplicated workflow blocks. The core change introduces two new utility functions in apps/sim/lib/naming.ts: normalizeBlockName() which converts names to lowercase and removes spaces (mirroring server-side normalization), and generateUniqueBlockDuplicateName() which creates unique names using the standardized " N" format.

The implementation addresses a UX issue where block duplication could create confusing name collisions, particularly when different naming variants normalize to the same string (e.g., "My Agent" vs "myagent"). The solution ensures consistency across both collaborative workflows (use-collaborative-workflow.ts) and local workflows (stores/workflows/workflow/store.ts) by replacing their separate naming logic with the shared utility.

The naming algorithm intelligently handles numeric suffixes - if a source name ends with whitespace and digits, it increments from that number; otherwise it starts from 1. It then loops through candidates until finding one that doesn't create a normalized collision. The updateBlockName function in the workflow store also now uses the shared normalizeBlockName to prevent drift between client and server validation rules.

Comprehensive test coverage validates edge cases including existing numeric suffixes, normalized collisions, gap filling in numbering sequences, whitespace handling, mixed case scenarios, and fallback behavior for empty names. This change maintains the product decision to handle uniqueness client-side only while keeping server behavior unchanged.

Confidence score: 4/5

• This PR is safe to merge with low risk of production issues
• Score reflects well-structured implementation with comprehensive tests, but complexity in naming logic warrants careful review
• Pay close attention to the naming utility functions in apps/sim/lib/naming.ts for potential edge cases

_{4 files reviewed, no comments}

_{Edit Code Review Bot Settings | Greptile}