Skip to content

feat[webhook]: added generic webhook#130

Merged
waleedlatif1 merged 3 commits intomainfrom
feat/webhook
Mar 21, 2025
Merged

feat[webhook]: added generic webhook#130
waleedlatif1 merged 3 commits intomainfrom
feat/webhook

Conversation

@waleedlatif1
Copy link
Collaborator

Description

Added support for generic webhooks.

Fixes #112

Type of change

Please delete options that are not relevant.

  • [y] New feature (non-breaking change which adds functionality)

How Has This Been Tested?

I configured a generic webhook, and ran the test to confirm it worked. Then, I took the cURL that it generated and ran it in my terminal and I was able to trigger my workflow.

Checklist:

  • [y] My code follows the style guidelines of this project
  • [y] I have performed a self-review of my own code
  • [y] I have commented my code, particularly in hard-to-understand areas
  • [y] My changes generate no new warnings
  • [y] I have added tests that prove my fix is effective or that my feature works
  • [y] Any dependent changes have been merged and published in downstream modules
  • [y] I have updated version numbers as needed (if needed)

Security Considerations:

  • [y] My changes do not introduce any new security vulnerabilities
  • [y] I have considered the security implications of my changes

Additional Information:

Could use some styling updates on the webhook modal, since the modal contains all the instructions and logic for the whatsapp webhook and the general one too. The styling is consistent across the differnet webhook providers but could be more consistent, and we will need toseparate out this code into smaller functions considering we will have many more webhook integrations in the future.

@vercel
Copy link

vercel bot commented Mar 21, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 21, 2025 0:07am
sim ❌ Failed (Inspect) Mar 21, 2025 0:07am

@waleedlatif1 waleedlatif1 merged commit 37567b4 into main Mar 21, 2025
4 of 5 checks passed
@waleedlatif1 waleedlatif1 deleted the feat/webhook branch March 21, 2025 00:17
RadoBoiii pushed a commit to RadoBoiii/sim-fork that referenced this pull request Apr 13, 2025
* added logic to support generic webhooks

* fixed style of generic webhook

* fixed style of generic webhook
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[REQUEST] General Webhook

1 participant