Skip to content

refactor[landing]: use github api to fetch stars instead of hardcoding#134

Merged
waleedlatif1 merged 1 commit intosimstudioai:mainfrom
faizancodes:fetch-gh-stars
Mar 21, 2025
Merged

refactor[landing]: use github api to fetch stars instead of hardcoding#134
waleedlatif1 merged 1 commit intosimstudioai:mainfrom
faizancodes:fetch-gh-stars

Conversation

@faizancodes
Copy link
Contributor

Description

Instead of hard coding the number of GitHub stars, this uses the GitHub api to fetch the count. This required turning the landing page into a server component and separate the client-facing parts into their own client component.

Type of change

Please delete options that are not relevant.

  • [y] Code refactoring (no functional changes)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration.

Checklist:

  • [y] My code follows the style guidelines of this project
  • [y] I have performed a self-review of my own code
  • [y] I have commented my code, particularly in hard-to-understand areas
  • [y] My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules
  • I have updated version numbers as needed (if needed)

Security Considerations:

  • [y] My changes do not introduce any new security vulnerabilities
  • [y] I have considered the security implications of my changes

@vercel
Copy link

vercel bot commented Mar 21, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 21, 2025 4:48pm

@vercel
Copy link

vercel bot commented Mar 21, 2025

@faizancodes is attempting to deploy a commit to the Sim Studio Team on Vercel.

A member of the Team first needs to authorize it.

@waleedlatif1 waleedlatif1 merged commit 4128bfe into simstudioai:main Mar 21, 2025
3 of 4 checks passed
RadoBoiii pushed a commit to RadoBoiii/sim-fork that referenced this pull request Apr 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants