Add redis tls

[Sg312]

Summary

Add redis tls to connect to elasticache

Fixes #(issue)

Type of Change

• Bug fix

Testing

Manual

Checklist

• Code follows project style guidelines
• Self-reviewed my changes
• Tests added/updated and passing
• No new warnings introduced
• I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Preview	Comments	Updated (UTC)
sim	Ready	Preview	Comment	Sep 30, 2025 3:22am

1 Skipped Deployment

Project	Deployment	Preview	Comments	Updated (UTC)
docs	Skipped			Sep 30, 2025 3:22am

[greptile-apps]

Greptile Overview

Summary

This PR enables TLS encryption for Redis connections by adding `tls: {}` to the Redis client configuration in `apps/sim/lib/redis.ts`. The change is designed to support AWS ElastiCache instances that have transit encryption enabled, which is a common security requirement in production environments. When ElastiCache is configured with encryption in transit, Redis clients must establish TLS connections to successfully communicate with the cluster.

The implementation uses an empty TLS configuration object, which instructs the ioredis library to use default TLS settings. This approach is typically sufficient for most cloud-hosted Redis services and provides a simple way to enable encrypted connections without requiring additional certificate configuration.

This change integrates with the existing Redis client setup in the codebase, which appears to be used for caching and session management based on the ioredis library usage. The modification maintains backward compatibility with the existing Redis connection logic while adding the necessary security layer for encrypted Redis instances.

PR Description Notes:

• The PR description is incomplete - it uses the template placeholders without filling in specific details about the Redis TLS implementation
• Missing information about which issue this fixes, testing methodology, and the type of change classification

Important Files Changed

Changed Files

Filename	Score	Overview
apps/sim/lib/redis.ts	2/5	Added unconditional TLS configuration to Redis client which may break non-TLS environments

Confidence score: 2/5

• This PR introduces a potentially breaking change that could cause Redis connection failures in development or non-TLS environments
• Score reflects the unconditional nature of the TLS enablement without environment-specific logic or proper testing validation
• Pay close attention to apps/sim/lib/redis.ts as it needs conditional TLS logic based on environment configuration

Sequence Diagram

sequenceDiagram
    participant User
    participant App as "Application"
    participant Redis as "getRedisClient()"
    participant IORedis as "IORedis Client"
    participant ElastiCache as "AWS ElastiCache"

    User->>App: "Initiates request"
    App->>Redis: "getRedisClient()"
    
    alt Redis URL configured
        Redis->>Redis: "Check if globalRedisClient exists"
        
        alt Client doesn't exist
            Redis->>IORedis: "new Redis(redisUrl, options)"
            Note over IORedis: "Options include:<br/>- keepAlive: 1000<br/>- connectTimeout: 5000<br/>- maxRetriesPerRequest: 3<br/>- tls: {} (NEW)<br/>- retryStrategy"
            IORedis->>ElastiCache: "Connect with TLS encryption"
            ElastiCache-->>IORedis: "TLS handshake & connection"
            IORedis-->>Redis: "Return client instance"
            Redis->>Redis: "Set up error handlers"
            Redis->>Redis: "Set up connect handlers"
            Redis-->>App: "Return Redis client"
        else Client exists
            Redis-->>App: "Return existing client"
        end
        
        App->>IORedis: "Redis operations (set, get, exists, etc.)"
        IORedis->>ElastiCache: "Encrypted commands via TLS"
        ElastiCache-->>IORedis: "Encrypted responses via TLS"
        IORedis-->>App: "Operation results"
        
    else Redis URL not configured
        Redis-->>App: "Return null"
        App->>App: "Use in-memory cache fallback"
    end
    
    alt Connection error occurs
        ElastiCache-->>IORedis: "Connection error"
        IORedis->>Redis: "Emit 'error' event"
        Redis->>Redis: "Log error & reset globalRedisClient"
        Redis->>Redis: "Apply retry strategy"
    end
    
    App-->>User: "Response"

Loading

_{1 file reviewed, 1 comment}

_{Edit Code Review Agent Settings | Greptile}

[greptile-apps]

style: TLS is enabled unconditionally for all environments. Consider making this conditional based on environment variables (e.g., tls: process.env.REDIS_TLS === 'true' ? {} : undefined) to avoid connection issues in development environments that don't use TLS.

Prompt To Fix With AI

This is a comment left during a code review.
Path: apps/sim/lib/redis.ts
Line: 44:44

Comment:
style: TLS is enabled unconditionally for all environments. Consider making this conditional based on environment variables (e.g., `tls: process.env.REDIS_TLS === 'true' ? {} : undefined`) to avoid connection issues in development environments that don't use TLS.

How can I resolve this? If you propose a fix, please make it concise.