Skip to content

Conversation

@arunabhcode
Copy link
Contributor

@arunabhcode arunabhcode commented Mar 23, 2025

Description

This PR will address Ollama integration into sim-studio for enabling local model use.

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

Will fill the rest of this out at before converting to reviewable PR.

How Has This Been Tested?

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules
  • I have updated version numbers as needed (if needed)

Security Considerations:

  • My changes do not introduce any new security vulnerabilities
  • I have considered the security implications of my changes

Additional Information:

Any additional information, configuration or data that might be necessary to reproduce the issue or use the feature.

@vercel
Copy link

vercel bot commented Mar 23, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 29, 2025 2:47am

@vercel
Copy link

vercel bot commented Mar 23, 2025

@arunabhcode is attempting to deploy a commit to the Sim Studio Team on Vercel.

A member of the Team first needs to authorize it.

@arunabhcode
Copy link
Contributor Author

Start of this PR, initially just added the orchestration part. Will test and start to add the logic after.

@waleedlatif1 waleedlatif1 self-requested a review March 23, 2025 23:04
@waleedlatif1 waleedlatif1 force-pushed the main branch 2 times, most recently from 1bc12e1 to fb5bd43 Compare March 25, 2025 08:13
@vercel
Copy link

vercel bot commented Mar 27, 2025

Deployment failed with the following error:

The provided GitHub repository does not contain the requested branch or commit reference. Please ensure the repository is not empty.

waleedlatif1
waleedlatif1 previously approved these changes Mar 28, 2025
Comment on lines 21 to 33
// Evaluate options if it's a function and deduplicate based on values
const evaluatedOptions = useMemo(() => {
const rawOptions = typeof options === 'function' ? options() : options
const seen = new Set<string>()
return rawOptions.filter(option => {
const value = typeof option === 'string' ? option : option.id
if (seen.has(value)) return false
seen.add(value)
return true
})
}, [options])


Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@arunabhcode i like that, getModelProviders and getInitializedModelProviders

@waleedlatif1
Copy link
Collaborator

@arunabhcode tests are failing, but I left a review so once this is resolved we can merge it in

arunabhcode and others added 9 commits March 28, 2025 16:26
…ent docker compose files and add a shell script to toggle between the deployment docker compose files

add base ollama.ts implementation

add latest attempt to fetch Ollama models dynamically

fix ollama dynamic model fetching, models now being rendered on GUI

fix package and package-lock.json to remove ollama dependency and add types.ts for ollama

switch MODEL_PROVIDERS to getModelProviders

make dynamic ollama model dropdown change using zustland store

make dynamic ollama model changes to router and evaluator ts too
…ag to start_simstudio_docker.sh with ollama service
@waleedlatif1 waleedlatif1 merged commit fe2c7d8 into simstudioai:main Mar 29, 2025
3 of 4 checks passed
@arunabhcode arunabhcode deleted the ollama-ticket branch March 29, 2025 23:02
RadoBoiii pushed a commit to RadoBoiii/sim-fork that referenced this pull request Apr 13, 2025
…oai#153)

* feat(ollama): add ollama package dependency, add two separate deployment docker compose files and add a shell script to toggle between the deployment docker compose files

add base ollama.ts implementation

add latest attempt to fetch Ollama models dynamically

fix ollama dynamic model fetching, models now being rendered on GUI

fix package and package-lock.json to remove ollama dependency and add types.ts for ollama

switch MODEL_PROVIDERS to getModelProviders

make dynamic ollama model dropdown change using zustland store

make dynamic ollama model changes to router and evaluator ts too

* feat(ollama): fix evaluated options by de-duplicating it

* feat(ollama): make README.md change to reflect local model workflow

* feat(ollama): add base non-ollama docker compose file, add --local flag to start_simstudio_docker.sh with ollama service

* feat(ollama): fix README.md local model instructions

* feat(ollama): remove de-duplication logic and separate getModelProviders into two

* fix non-local init and translate.ts

* create combined docker-compose file and fix start_simstudio_docker script too

* update package-lock.json

* feat(ollama): fix README.md instructions and docker compose

---------

Co-authored-by: Arunabh Sharma <arunabh.sharma@supernal.aero>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants