-
Notifications
You must be signed in to change notification settings - Fork 3.1k
fix(devcontainer): use bunx for concurrently command #2723
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(devcontainer): use bunx for concurrently command #2723
Conversation
- Changed 'concurrently' to 'bunx concurrently' in dev:full script - Fixes issue where concurrently command is not found in PATH - Resolves simstudioai#2661
|
@Patel230 is attempting to deploy a commit to the Sim Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Greptile Overview
Greptile Summary
Fixed devcontainer command execution error by changing concurrently to bunx concurrently in the dev:full script, ensuring Bun properly resolves the binary from node_modules/.bin/.
Key Changes:
- Modified
dev:fullscript to usebunx concurrentlyinstead of bareconcurrentlycommand - Aligns with existing codebase patterns (root package.json uses
bunxforbiome, db package usesbunxfordrizzle-kit) concurrentlyis properly defined as a devDependency (v9.1.0)
Impact:
- Resolves "command not found" error when running
bun run dev:fullin devcontainer environments - No breaking changes - maintains the same functionality with proper binary resolution
Confidence Score: 5/5
- This PR is safe to merge with no risk
- The change is a minimal, well-justified fix that follows established patterns in the codebase. Using
bunxis the standard approach in this project (as seen in root and db packages),concurrentlyis properly defined as a devDependency, and the change only affects script execution without modifying any application logic. - No files require special attention
Important Files Changed
File Analysis
| Filename | Score | Overview |
|---|---|---|
| apps/sim/package.json | 5/5 | Fixed dev:full script to use bunx concurrently instead of bare concurrently, resolving PATH issue in devcontainer environments |
Sequence Diagram
sequenceDiagram
participant User
participant Shell
participant Bun
participant Concurrently
participant NextDev as Next Dev Server
participant Sockets as Socket Server
User->>Shell: bun run dev:full
Shell->>Bun: Execute package.json script
Note over Bun: Before: concurrently (PATH lookup fails in devcontainer)
Note over Bun: After: bunx concurrently (resolves from node_modules/.bin)
Bun->>Bun: bunx resolves concurrently binary
Bun->>Concurrently: Execute with -n "App,Realtime" -c "cyan,magenta"
par Run App
Concurrently->>NextDev: bun run dev
NextDev-->>User: Next.js dev server on port 3000
and Run Realtime
Concurrently->>Sockets: bun run dev:sockets
Sockets-->>User: Socket.io server running
end
Note over User,Sockets: Both servers run concurrently with colored output
✅ Testing ResultsEnvironment:
Test Results: ✅ Before Fix: $ bun run dev:full
$ concurrently -n "App,Realtime" ...
/bin/bash: line 1: concurrently: command not found
error: script "dev:full" exited with code 127✅ After Fix: $ bun run dev:full
$ bunx concurrently -n "App,Realtime" ...
[App] $ next dev --port 3000
[Realtime] $ bun run socket/index.ts
✓ Ready in 2.3sVerification:
Conclusion: cc @cabaucom376 (original reporter) - This should fix the devcontainer issue you reported |
|
Thank you so much @waleedlatif1 !! |

Description
Fixes #2661
Changed
concurrentlytobunx concurrentlyin thedev:fullscript to resolve the "command not found" error when running the dev environment.Problem
When running
bun run dev:fullin a devcontainer, the script fails with:Solution
The issue occurs because
concurrentlyis not in the system PATH. Usingbunx concurrentlyensures that Bun properly resolves and executes the binary fromnode_modules/.bin/.Changes
apps/sim/package.json: Changedconcurrentlytobunx concurrentlyin thedev:fullscriptTesting
concurrentlyis installed as a devDependencynode_modules/.bin/concurrentlyType of Change