Skip to content

Conversation

@waleedlatif1
Copy link
Collaborator

Summary

  • Add Vertex AI env vars (VERTEX_PROJECT, VERTEX_LOCATION)
  • Add organizations/permission groups env vars (ADMIN_API_KEY, ACCESS_CONTROL_ENABLED, ORGANIZATIONS_ENABLED, NEXT_PUBLIC_*)
  • Add TELEMETRY_ENDPOINT for OTLP logging

Type of Change

  • New feature

Testing

Tested helm template renders correctly

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel
Copy link

vercel bot commented Jan 21, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
docs Ready Ready Preview, Comment Jan 21, 2026 7:30pm

Request Review

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Jan 21, 2026

Greptile Summary

This PR adds environment variable configuration to the Helm chart for three new feature areas: Vertex AI integration, organizations/permission groups, and OTLP telemetry.

Changes Made:

  • Added VERTEX_PROJECT and VERTEX_LOCATION for Google Vertex AI configuration (lines 110-112)
  • Added TELEMETRY_ENDPOINT for OTLP logging/traces (line 82)
  • Added ADMIN_API_KEY for admin API authentication (line 154)
  • Added four organization/access control flags: ACCESS_CONTROL_ENABLED, ORGANIZATIONS_ENABLED, and their corresponding NEXT_PUBLIC_* variants for UI visibility (lines 157-160)
  • Minor formatting fix: removed trailing whitespace on line 79

Review Findings:

  • All added variables are properly defined in apps/sim/lib/core/config/env.ts with appropriate validation schemas
  • Variables are actively used throughout the codebase (Vertex AI in providers, telemetry in instrumentation, admin/orgs in API routes)
  • Documentation comments are clear and follow existing patterns
  • Default values are sensible (empty strings for optional configs, "us-central1" for Vertex location, "false" for feature flags)
  • Consistent with the existing helm chart structure and naming conventions

Confidence Score: 5/5

  • This PR is safe to merge with no concerns
  • All added environment variables are properly documented, have sensible defaults, match existing patterns in the codebase, and are used by the application code
  • No files require special attention

Important Files Changed

Filename Overview
helm/sim/values.yaml Added env vars for Vertex AI, organizations/access control, admin API, and telemetry - all properly documented and consistent with codebase

Sequence Diagram

sequenceDiagram
    participant Helm as Helm Chart
    participant K8s as Kubernetes
    participant App as Sim App Pod
    participant Vertex as Google Vertex AI
    participant OTLP as OTLP Collector
    participant Admin as Admin API

    Note over Helm: values.yaml defines env vars
    Helm->>K8s: Apply deployment with env vars
    K8s->>App: Inject env variables
    
    Note over App: New capabilities enabled
    
    alt Vertex AI Configuration
        App->>Vertex: Use VERTEX_PROJECT & VERTEX_LOCATION
        Vertex-->>App: AI model responses
    end
    
    alt Telemetry Configuration
        App->>OTLP: Send traces/logs to TELEMETRY_ENDPOINT
        OTLP-->>App: Acknowledgment
    end
    
    alt Organizations & Access Control
        App->>App: Check ACCESS_CONTROL_ENABLED
        App->>App: Check ORGANIZATIONS_ENABLED
        App->>App: Render UI based on NEXT_PUBLIC_* flags
        Admin->>App: Admin API calls with ADMIN_API_KEY
        App-->>Admin: Organization/user management operations
    end
Loading

@waleedlatif1 waleedlatif1 merged commit 0ea0256 into staging Jan 21, 2026
12 checks passed
@waleedlatif1 waleedlatif1 deleted the chore/helm branch January 21, 2026 19:36
waleedlatif1 added a commit that referenced this pull request Jan 22, 2026
* fix(zustand): updated to useShallow from deprecated createWithEqualityFn (#2919)

* fix(logger): use direct env access for webpack inlining (#2920)

* fix(notifications): text overflow with line-clamp (#2921)

* chore(helm): add env vars for Vertex AI, orgs, and telemetry (#2922)

* fix(auth): improve reset password flow and consolidate brand detection (#2924)

* fix(auth): improve reset password flow and consolidate brand detection

* fix(auth): set errorHandled for EMAIL_NOT_VERIFIED to prevent duplicate error

* fix(auth): clear success message on login errors

* chore(auth): fix import order per lint

* fix(action-bar): duplicate subflows with children (#2923)

* fix(action-bar): duplicate subflows with children

* fix(action-bar): add validateTriggerPaste for subflow duplicate

* fix(resolver): agent response format, input formats, root level (#2925)

* fix(resolvers): agent response format, input formats, root level

* fix response block initial seeding

* fix tests

* fix(messages-input): fix cursor alignment and auto-resize with overlay (#2926)

* fix(messages-input): fix cursor alignment and auto-resize with overlay

* fixed remaining zustand warnings

* fix(stores): remove dead code causing log spam on startup (#2927)

* fix(stores): remove dead code causing log spam on startup

* fix(stores): replace custom tools zustand store with react query cache

* improvement(ui): use BrandedButton and BrandedLink components (#2930)

- Refactor auth forms to use BrandedButton component
- Add BrandedLink component for changelog page
- Reduce code duplication in login, signup, reset-password forms
- Update star count default value

* fix(custom-tools): remove unsafe title fallback in getCustomTool (#2929)

* fix(custom-tools): remove unsafe title fallback in getCustomTool

* fix(custom-tools): restore title fallback in getCustomTool lookup

Custom tools are referenced by title (custom_${title}), not database ID.
The title fallback is required for client-side tool resolution to work.

* fix(null-bodies): empty bodies handling (#2931)

* fix(null-statuses): empty bodies handling

* address bugbot comment

* fix(token-refresh): microsoft, notion, x, linear (#2933)

* fix(microsoft): proactive refresh needed

* fix(x): missing token refresh flag

* notion and linear missing flag too

* address bugbot comment

* fix(auth): handle EMAIL_NOT_VERIFIED in onError callback (#2932)

* fix(auth): handle EMAIL_NOT_VERIFIED in onError callback

* refactor(auth): extract redirectToVerify helper to reduce duplication

* fix(workflow-selector): use dedicated selector for workflow dropdown (#2934)

* feat(workflow-block): preview (#2935)

* improvement(copilot): tool configs to show nested props (#2936)

* fix(auth): add genericOAuth providers to trustedProviders (#2937)

---------

Co-authored-by: Vikhyath Mondreti <vikhyathvikku@gmail.com>
Co-authored-by: Emir Karabeg <78010029+emir-karabeg@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants