feat(timeout): add API block timeout configuration #3053

waleedlatif1 · 2026-01-28T21:59:29Z

Summary

Fixes timeout configuration not being honored for API blocks and adds proper validation.

Changes

1. Internal Routes Timeout Support (`apps/sim/tools/index.ts`)

Added AbortController to support timeouts for internal routes (/api/*)
Previously only external URLs honored the timeout setting
Internal routes now use same 5-minute default as external routes

2. Type Coercion Fix (`apps/sim/tools/utils.ts`)

The short-input subBlock returns a string but code expected a number
Now properly converts using Number() with validation

3. Timeout Validation (`apps/sim/tools/utils.ts`)

Validates timeout is a finite positive number
Rejects negative values, zero, Infinity, and NaN
Enforces max timeout of 600000ms (10 minutes) as documented

4. Consistent Error Messages (`apps/sim/lib/core/security/input-validation.ts`)

External routes now report actual timeout value in error message
Both internal and external routes use consistent format: Request timed out after Xms

5. Cleanup (`apps/sim/tools/index.ts`)

Removed redundant clearTimeout in catch block (finally always executes)

Test Plan

TypeScript compiles without errors
Lint passes
Core tools tests pass
Manual test: API block with custom timeout on external URL
Manual test: API block with custom timeout on internal route
Manual test: Timeout exceeding 600000ms gets clamped

Fixes #2786
Fixes #2242

vercel · 2026-01-28T21:59:34Z

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Review	Updated (UTC)
docs	Skipped		Jan 29, 2026 1:13am

…oercion - Add AbortController support for internal routes (/api/*) to honor timeout - Fix type coercion: convert string timeout from short-input to number - Handle NaN gracefully by falling back to undefined (default timeout) Fixes #2786 Fixes #2242

greptile-apps · 2026-01-28T22:02:10Z

Greptile Overview

Greptile Summary

This PR fixes timeout configuration for API blocks by adding support for internal routes and fixing type coercion issues.

Key Changes:

Added AbortController to support timeout for internal routes (/api/*) which previously ignored the timeout parameter
Fixed type coercion bug where string timeout values from UI weren't converted to numbers (the as number cast didn't actually convert)
Added validation to ensure timeout is positive (negative values would cause immediate abort in JavaScript)
Added timeout subBlock to API block UI for user configuration

Additional Changes:

Search modal refactoring (unrelated to timeout feature) - removed description and keywords fields, improved filter performance
These changes appear to be performance optimizations bundled in the same commit

The timeout implementation correctly handles both internal and external routes, with proper error handling and cleanup.

Confidence Score: 5/5

Safe to merge - fixes critical timeout bugs with proper validation and error handling
The timeout implementation is clean and follows best practices. Type coercion fix prevents runtime errors. AbortController pattern is correctly implemented with proper cleanup in finally block. No security issues or breaking changes.
No files require special attention

Important Files Changed

Filename	Overview
apps/sim/tools/index.ts	Added AbortController timeout support for internal routes, matching external route behavior
apps/sim/tools/utils.ts	Fixed type coercion for timeout param and added validation for positive numbers
apps/sim/blocks/blocks/api.ts	Added timeout subBlock UI configuration with proper description
apps/sim/tools/http/types.ts	Added timeout field to RequestParams interface

Sequence Diagram

sequenceDiagram
    participant UI as API Block UI
    participant Block as api.ts
    participant Utils as tools/utils.ts
    participant Index as tools/index.ts
    participant Fetch as fetch/secureFetch

    UI->>Block: User sets timeout (string)
    Block->>Utils: formatRequestParams(tool, params)
    Note over Utils: Convert string to number<br/>Validate timeout > 0
    Utils->>Index: executeToolRequest(requestParams)
    
    alt Internal Route (/api/*)
        Note over Index: Create AbortController
        Index->>Index: setTimeout(timeout || 300000)
        Index->>Fetch: fetch(url, { signal })
        alt Timeout occurs
            Index->>Index: controller.abort()
            Fetch-->>Index: AbortError
            Index-->>Block: Error: "Request timed out after Xms"
        else Success
            Fetch-->>Index: Response
            Index->>Index: clearTimeout()
            Index-->>Block: Response data
        end
    else External URL
        Index->>Fetch: secureFetchWithPinnedIP(url, { timeout })
        Note over Fetch: Native timeout support<br/>via requestOptions.timeout
        alt Timeout occurs
            Fetch-->>Index: Timeout error
            Index-->>Block: Error
        else Success
            Fetch-->>Index: Response
            Index-->>Block: Response data
        end
    end

greptile-apps

_{5 files reviewed, 1 comment}

_{Edit Code Review Agent Settings | Greptile}

apps/sim/tools/index.ts

apps/sim/lib/core/security/input-validation.ts

apps/sim/tools/utils.ts

Negative timeout values would cause immediate request abort since JavaScript treats negative setTimeout delays as 0.

waleedlatif1 · 2026-01-28T22:38:43Z

@greptile

greptile-apps

_{3 files reviewed, no comments}

_{Edit Code Review Agent Settings | Greptile}

...im/app/workspace/[workspaceId]/w/components/sidebar/components/search-modal/search-modal.tsx

apps/sim/stores/modals/search/store.ts

waleedlatif1 · 2026-01-29T00:20:57Z

@greptile

greptile-apps

_{4 files reviewed, 1 comment}

_{Edit Code Review Agent Settings | Greptile}

apps/sim/tools/utils.ts

apps/sim/tools/index.ts

apps/sim/tools/utils.ts

- Internal routes now use same 5-minute default as external routes - Added Number.isFinite() check to reject Infinity values

waleedlatif1 · 2026-01-29T00:38:17Z

@greptile

- Clamp timeout to max 600000ms (10 minutes) as documented - External routes now report timeout value in error message

greptile-apps

_{4 files reviewed, no comments}

_{Edit Code Review Agent Settings | Greptile}

...im/app/workspace/[workspaceId]/w/components/sidebar/components/search-modal/search-modal.tsx

cursor

Cursor Bugbot has reviewed your changes and found 3 potential issues.

^{Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.}

cursor · 2026-01-29T01:25:54Z

apps/sim/tools/utils.ts

+      ? Math.min(timeout, MAX_TIMEOUT_MS)
+      : undefined
+
+  return { url, method, headers, body, timeout: validTimeout }


Timeout parameter incorrectly applied to all tools

Medium Severity

The new timeout handling in formatRequestParams extracts params.timeout for ALL tools and uses it as the HTTP request timeout. However, tools like firecrawl, apify, and elasticsearch have their own timeout parameter that serves a different purpose—it's an API-level parameter (e.g., how long firecrawl should spend scraping), not an HTTP request timeout. When a user sets timeout=60000 for firecrawl intending 60 seconds of scrape time, the HTTP request will now also abort after 60 seconds, potentially failing before the API completes its work and returns a response.

Additional Locations (1)

apps/sim/tools/index.ts#L658-L659

cursor · 2026-01-29T01:25:54Z

apps/sim/tools/index.ts

-      })
+      // Set up AbortController for timeout support on internal routes
+      const controller = new AbortController()
+      const timeout = requestParams.timeout || 300000


Duplicated magic number for default timeout value

Low Severity

The magic number 300000 (5 minute timeout) is duplicated in two locations added by this PR. The codebase already has centralized timeout constants like A2A_DEFAULT_TIMEOUT in lib/a2a/constants.ts and CHAT_REQUEST_TIMEOUT_MS in app/chat/constants.ts with the same value. A shared constant like DEFAULT_REQUEST_TIMEOUT_MS would ensure consistency and make future changes easier to manage across the codebase.

Additional Locations (1)

apps/sim/lib/core/security/input-validation.ts#L933-L934

cursor · 2026-01-29T01:25:54Z

...im/app/workspace/[workspaceId]/w/components/sidebar/components/search-modal/search-modal.tsx

+        nativeInputValueSetter.call(inputRef.current, '')
+        inputRef.current.dispatchEvent(new Event('input', { bubbles: true }))
+      }
+      inputRef.current.focus()


Overly complex DOM manipulation to clear input

Low Severity

The new approach uses Object.getOwnPropertyDescriptor(window.HTMLInputElement.prototype, 'value')?.set to clear the search input, which is more complex than the previous controlled React state pattern (setSearch('')). This DOM manipulation technique relies on browser implementation details and is harder to understand and maintain than standard React state management.

waleedlatif1 force-pushed the fix/timeout branch from 426ccb2 to fe99521 Compare January 28, 2026 22:00

vercel bot temporarily deployed to Preview January 28, 2026 22:00 Inactive

waleedlatif1 added 2 commits January 28, 2026 14:00

feat(timeout): add timeout subblock to the api block

06ce137

waleedlatif1 force-pushed the fix/timeout branch from fe99521 to 64f7b84 Compare January 28, 2026 22:00

vercel bot temporarily deployed to Preview January 28, 2026 22:00 Inactive

waleedlatif1 changed the base branch from main to staging January 28, 2026 22:01

waleedlatif1 changed the title ~~fix(timeout): honor API block timeout configuration~~ fix(timeout): add API block timeout configuration Jan 28, 2026

greptile-apps bot reviewed Jan 28, 2026

View reviewed changes

apps/sim/tools/index.ts Outdated Show resolved Hide resolved

waleedlatif1 changed the title ~~fix(timeout): add API block timeout configuration~~ feat(timeout): add API block timeout configuration Jan 28, 2026

vercel bot temporarily deployed to Preview January 28, 2026 22:05 Inactive

fix: remove redundant clearTimeout in catch block

e2023dc

waleedlatif1 force-pushed the fix/timeout branch from ec06ab6 to e2023dc Compare January 28, 2026 22:05

vercel bot temporarily deployed to Preview January 28, 2026 22:05 Inactive

cursor bot reviewed Jan 28, 2026

View reviewed changes

apps/sim/lib/core/security/input-validation.ts Show resolved Hide resolved

apps/sim/tools/utils.ts Outdated Show resolved Hide resolved

apps/sim/tools/utils.ts Outdated Show resolved Hide resolved

vercel bot temporarily deployed to Preview January 28, 2026 22:35 Inactive

fix: validate timeout is positive number

d57fa9f

Negative timeout values would cause immediate request abort since JavaScript treats negative setTimeout delays as 0.

waleedlatif1 force-pushed the fix/timeout branch from 970228e to d57fa9f Compare January 28, 2026 22:36

vercel bot temporarily deployed to Preview January 28, 2026 22:36 Inactive

update docs image, update search modal performance

7b0a911

vercel bot deployed to Preview January 28, 2026 22:40 View deployment

greptile-apps bot reviewed Jan 28, 2026

View reviewed changes

cursor bot reviewed Jan 28, 2026

View reviewed changes

...im/app/workspace/[workspaceId]/w/components/sidebar/components/search-modal/search-modal.tsx Show resolved Hide resolved

removed unused keywords type

afae856

vercel bot temporarily deployed to Preview January 28, 2026 23:38 Inactive

cursor bot reviewed Jan 28, 2026

View reviewed changes

...im/app/workspace/[workspaceId]/w/components/sidebar/components/search-modal/search-modal.tsx Show resolved Hide resolved

apps/sim/stores/modals/search/store.ts Show resolved Hide resolved

ack comments

bad68f9

vercel bot temporarily deployed to Preview January 29, 2026 00:20 Inactive

greptile-apps bot reviewed Jan 29, 2026

View reviewed changes

apps/sim/tools/utils.ts Outdated Show resolved Hide resolved

cleanup

d442ab7

vercel bot temporarily deployed to Preview January 29, 2026 00:25 Inactive

cursor bot reviewed Jan 29, 2026

View reviewed changes

apps/sim/tools/index.ts Outdated Show resolved Hide resolved

apps/sim/tools/utils.ts Outdated Show resolved Hide resolved

vercel bot temporarily deployed to Preview January 29, 2026 00:37 Inactive

fix: add default timeout for internal routes and validate finite timeout

8104f29

- Internal routes now use same 5-minute default as external routes - Added Number.isFinite() check to reject Infinity values

waleedlatif1 force-pushed the fix/timeout branch from accae9b to 8104f29 Compare January 29, 2026 00:37

vercel bot temporarily deployed to Preview January 29, 2026 00:38 Inactive

fix: enforce max timeout and improve error message consistency

927fc8e

- Clamp timeout to max 600000ms (10 minutes) as documented - External routes now report timeout value in error message

vercel bot temporarily deployed to Preview January 29, 2026 00:39 Inactive

greptile-apps bot reviewed Jan 29, 2026

View reviewed changes

cursor bot reviewed Jan 29, 2026

View reviewed changes

...im/app/workspace/[workspaceId]/w/components/sidebar/components/search-modal/search-modal.tsx Show resolved Hide resolved

remove unused code

dbb04ab

vercel bot temporarily deployed to Preview January 29, 2026 01:13 Inactive

waleedlatif1 merged commit 06d7ce7 into staging Jan 29, 2026
7 checks passed

waleedlatif1 deleted the fix/timeout branch January 29, 2026 01:14

waleedlatif1 mentioned this pull request Jan 29, 2026

v0.5.75: search modal overhaul, helm chart updates, run from block, terminal and visual debugging improvements #3058

Open

cursor bot reviewed Jan 29, 2026

View reviewed changes

feat(timeout): add API block timeout configuration #3053

feat(timeout): add API block timeout configuration #3053

Uh oh!

Conversation

waleedlatif1 commented Jan 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Changes

1. Internal Routes Timeout Support (apps/sim/tools/index.ts)

2. Type Coercion Fix (apps/sim/tools/utils.ts)

3. Timeout Validation (apps/sim/tools/utils.ts)

4. Consistent Error Messages (apps/sim/lib/core/security/input-validation.ts)

5. Cleanup (apps/sim/tools/index.ts)

Test Plan

Uh oh!

vercel bot commented Jan 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

greptile-apps bot commented Jan 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Greptile Overview

Greptile Summary

Confidence Score: 5/5

Important Files Changed

Sequence Diagram

Uh oh!

greptile-apps bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

waleedlatif1 commented Jan 28, 2026

Uh oh!

greptile-apps bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

waleedlatif1 commented Jan 29, 2026

Uh oh!

greptile-apps bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

waleedlatif1 commented Jan 29, 2026

Uh oh!

greptile-apps bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

cursor bot left a comment

Choose a reason for hiding this comment

Uh oh!

cursor bot Jan 29, 2026

Choose a reason for hiding this comment

Timeout parameter incorrectly applied to all tools

Uh oh!

cursor bot Jan 29, 2026

Choose a reason for hiding this comment

Duplicated magic number for default timeout value

Uh oh!

cursor bot Jan 29, 2026

Choose a reason for hiding this comment

Overly complex DOM manipulation to clear input

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

waleedlatif1 commented Jan 28, 2026 •

edited

Loading

1. Internal Routes Timeout Support (`apps/sim/tools/index.ts`)

2. Type Coercion Fix (`apps/sim/tools/utils.ts`)

3. Timeout Validation (`apps/sim/tools/utils.ts`)

4. Consistent Error Messages (`apps/sim/lib/core/security/input-validation.ts`)

5. Cleanup (`apps/sim/tools/index.ts`)

vercel bot commented Jan 28, 2026 •

edited

Loading

greptile-apps bot commented Jan 28, 2026 •

edited

Loading