-
Notifications
You must be signed in to change notification settings - Fork 3.3k
fix: terminal spacing, subflow disabled in preview #3055
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Greptile OverviewGreptile SummaryFixed terminal spacing between executions and added disabled state visualization for subflows in preview mode. Changes:
Issues found:
Confidence Score: 4/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant PW as PreviewWorkflow
participant SF as PreviewSubflow
participant UI as User Interface
Note over PW: Processing workflow blocks
PW->>PW: Check block.enabled ?? true
PW->>SF: Pass enabled prop to subflow data
Note over SF: Rendering subflow component
SF->>SF: Destructure enabled (default: true)
alt Subflow is disabled
SF->>UI: Show gray icon background
SF->>UI: Show muted text color
SF->>UI: Display "disabled" badge
else Subflow is enabled
SF->>UI: Show colored icon (blue/yellow)
SF->>UI: Show normal text color
SF->>UI: No badge displayed
end
Note over UI: Terminal spacing changes
UI->>UI: Render separator with mb-[6px]
UI->>UI: Render entry tree with pb-[6px]
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
3 files reviewed, 1 comment
| <div | ||
| className='flex h-[24px] w-[24px] flex-shrink-0 items-center justify-center rounded-[6px]' | ||
| style={{ backgroundColor: blockIconBg }} | ||
| style={{ backgroundColor: enabled ? blockIconBg : 'gray' }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hardcoded 'gray' violates styling rules - use CSS variable like var(--surface-4) or #808080
| style={{ backgroundColor: enabled ? blockIconBg : 'gray' }} | |
| style={{ backgroundColor: enabled ? blockIconBg : 'var(--surface-4)' }} |
Context Used: Context from dashboard - Tailwind CSS and styling conventions (source)
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
Prompt To Fix With AI
This is a comment left during a code review.
Path: apps/sim/app/workspace/[workspaceId]/w/components/preview/components/preview-workflow/components/subflow/subflow.tsx
Line: 99:99
Comment:
hardcoded `'gray'` violates styling rules - use CSS variable like `var(--surface-4)` or `#808080`
```suggestion
style={{ backgroundColor: enabled ? blockIconBg : 'var(--surface-4)' }}
```
**Context Used:** Context from `dashboard` - Tailwind CSS and styling conventions ([source](https://app.greptile.com/review/custom-context?memory=e1e9ca56-9819-463f-be67-0d2ba849ec4f))
<sub>Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!</sub>
How can I resolve this? If you propose a fix, please make it concise.
Summary
Type of Change
Testing
Solo.
Checklist