Skip to content

Conversation

@emir-karabeg
Copy link
Collaborator

Summary

  • Terminal: spacing between executions
  • Preview: subflow disabled showing

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation
  • Other: ___________

Testing

Solo.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel
Copy link

vercel bot commented Jan 28, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Review Updated (UTC)
docs Skipped Skipped Jan 28, 2026 11:41pm

Request Review

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Jan 28, 2026

Greptile Overview

Greptile Summary

Fixed terminal spacing between executions and added disabled state visualization for subflows in preview mode.

Changes:

  • Terminal: increased spacing from 4px to 6px for better visual separation between execution groups
  • Preview: added disabled state display for subflows with gray icon, muted text, and badge indicator
  • Data flow: enabled property now passed from block data through to subflow preview rendering

Issues found:

  • Hardcoded 'gray' string violates styling rules - should use CSS variable

Confidence Score: 4/5

  • Safe to merge with minor style improvement recommended
  • Changes are straightforward UI improvements with minimal risk. One minor styling issue (hardcoded color) should be addressed but doesn't block functionality
  • subflow.tsx needs minor fix for hardcoded color value

Important Files Changed

Filename Overview
apps/sim/app/workspace/[workspaceId]/w/[workflowId]/components/terminal/terminal.tsx Increased spacing between execution groups (4px to 6px) for better visual separation
apps/sim/app/workspace/[workspaceId]/w/components/preview/components/preview-workflow/components/subflow/subflow.tsx Added disabled state visualization with gray icon, muted text, and badge indicator
apps/sim/app/workspace/[workspaceId]/w/components/preview/components/preview-workflow/preview-workflow.tsx Passed enabled property from block to subflow preview data

Sequence Diagram

sequenceDiagram
    participant PW as PreviewWorkflow
    participant SF as PreviewSubflow
    participant UI as User Interface
    
    Note over PW: Processing workflow blocks
    PW->>PW: Check block.enabled ?? true
    PW->>SF: Pass enabled prop to subflow data
    
    Note over SF: Rendering subflow component
    SF->>SF: Destructure enabled (default: true)
    
    alt Subflow is disabled
        SF->>UI: Show gray icon background
        SF->>UI: Show muted text color
        SF->>UI: Display "disabled" badge
    else Subflow is enabled
        SF->>UI: Show colored icon (blue/yellow)
        SF->>UI: Show normal text color
        SF->>UI: No badge displayed
    end
    
    Note over UI: Terminal spacing changes
    UI->>UI: Render separator with mb-[6px]
    UI->>UI: Render entry tree with pb-[6px]
Loading

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3 files reviewed, 1 comment

Edit Code Review Agent Settings | Greptile

<div
className='flex h-[24px] w-[24px] flex-shrink-0 items-center justify-center rounded-[6px]'
style={{ backgroundColor: blockIconBg }}
style={{ backgroundColor: enabled ? blockIconBg : 'gray' }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hardcoded 'gray' violates styling rules - use CSS variable like var(--surface-4) or #808080

Suggested change
style={{ backgroundColor: enabled ? blockIconBg : 'gray' }}
style={{ backgroundColor: enabled ? blockIconBg : 'var(--surface-4)' }}

Context Used: Context from dashboard - Tailwind CSS and styling conventions (source)

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

Prompt To Fix With AI
This is a comment left during a code review.
Path: apps/sim/app/workspace/[workspaceId]/w/components/preview/components/preview-workflow/components/subflow/subflow.tsx
Line: 99:99

Comment:
hardcoded `'gray'` violates styling rules - use CSS variable like `var(--surface-4)` or `#808080`

```suggestion
            style={{ backgroundColor: enabled ? blockIconBg : 'var(--surface-4)' }}
```

**Context Used:** Context from `dashboard` - Tailwind CSS and styling conventions ([source](https://app.greptile.com/review/custom-context?memory=e1e9ca56-9819-463f-be67-0d2ba849ec4f))

<sub>Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!</sub>

How can I resolve this? If you propose a fix, please make it concise.

@emir-karabeg emir-karabeg merged commit 12d529d into staging Jan 28, 2026
6 checks passed
@emir-karabeg emir-karabeg deleted the fix/terminal branch January 28, 2026 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants