fix(client-exec): send correct client workflow state override#3143
Merged
icecrasher321 merged 1 commit intostagingfrom Feb 5, 2026
Merged
fix(client-exec): send correct client workflow state override#3143icecrasher321 merged 1 commit intostagingfrom
icecrasher321 merged 1 commit intostagingfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
Greptile OverviewGreptile SummaryFixed workflow execution validation by ensuring the client-side workflow state is always sent to the server as Key Changes:
Confidence Score: 5/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant Client as useWorkflowExecution
participant Stream as executionStream
participant API as /api/workflows/execute
participant Core as execution-core.ts
participant DB as Database
Note over Client: User triggers execution
Client->>Client: Read latest workflow state from store
Client->>Client: Build clientWorkflowState object
Note over Client: BEFORE: conditionally sent override<br/>AFTER: always sent override
Client->>Stream: execute({ workflowStateOverride })
Note over Stream: workflowStateOverride always defined now
Stream->>API: POST with workflowStateOverride
API->>Core: executeWorkflowCore(snapshot)
Note over Core: snapshot.metadata.workflowStateOverride
alt workflowStateOverride present
Core->>Core: Use client-side state (blocks, edges, loops, parallels)
Note over Core: Validates against current client state<br/>DB may be 1-2 seconds behind
else no override (old behavior)
Core->>DB: Load draft state from DB
Note over Core: Validates against DB state<br/>May be stale for 1-2 seconds
end
Core->>Core: Run validations on workflow state
Core-->>API: Execution result
API-->>Stream: SSE events stream
Stream-->>Client: Callbacks invoked
|
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
apps/sim/app/workspace/[workspaceId]/w/[workflowId]/hooks/use-workflow-execution.ts
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Need to send client side state as workflow state override correctly since db is out of sync for 1-2 seconds so validations must run on the former.
Type of Change
Testing
Tested manually
Checklist