fix(ollama): set OLLAMA_HOST from env variable#316
Merged
waleedlatif1 merged 1 commit intosimstudioai:mainfrom Apr 30, 2025
Merged
fix(ollama): set OLLAMA_HOST from env variable#316waleedlatif1 merged 1 commit intosimstudioai:mainfrom
waleedlatif1 merged 1 commit intosimstudioai:mainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@gabelazo is attempting to deploy a commit to the Sim Studio Team on Vercel. A member of the Team first needs to authorize it. |
|
|
||
| const logger = createLogger('Ollama Provider') | ||
| const OLLAMA_HOST = 'http://localhost:11434' | ||
| const OLLAMA_HOST = process.env.OLLAMA_HOST || 'http://localhost:11434' |
There was a problem hiding this comment.
Missing protocol enforcement for OLLAMA_HOST which could lead to connection issues
RadoBoiii
pushed a commit
to RadoBoiii/sim-fork
that referenced
this pull request
May 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context.
Fix for using local ollama instance running on host via host.docker.internal mapping. Currently hardcoded to localhost which results in ECONNREFUSED.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration.
Tested using docker compose with host mapping:
Checklist:
npm test)Security Considerations:
Additional Information:
Any additional information, configuration or data that might be necessary to reproduce the issue or use the feature.