Skip to content

feat(otel): added otel, persist settings to db, present user with the telemetry preferences & add privacy tab to settings#318

Merged
waleedlatif1 merged 5 commits intomainfrom
feat/telemetry
May 1, 2025
Merged

feat(otel): added otel, persist settings to db, present user with the telemetry preferences & add privacy tab to settings#318
waleedlatif1 merged 5 commits intomainfrom
feat/telemetry

Conversation

@waleedlatif1
Copy link
Copy Markdown
Collaborator

  • feat(otel): added otel, persist settings to db, present user with the telemetry preferences & add privacy tab to settings
  • updated telemetry endpoint
  • add protected subdomains for chat deploy

Description

Added otel, persist settings to db, present user with the telemetry preferences & add privacy tab to settings. User's can bring their own telemetry collector very easily, just changing the URL. Otherwise, if they opt-in then telemetry will be sent to our public collection endpoint.

Also modified settings modal to persist data. Previously, we were using the client-side zustand store but this will need to be refactored for multiplayer, so we just persisted it to the settings database.

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Added unit tests, ran and tested manually.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works
  • All tests pass locally and in CI (npm test)
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • I have updated version numbers as needed (if needed)
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Security Considerations:

  • My changes do not introduce any new security vulnerabilities
  • I have considered the security implications of my changes

@vercel
Copy link
Copy Markdown

vercel Bot commented May 1, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 1, 2025 6:49am
sim ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 1, 2025 6:49am

@waleedlatif1 waleedlatif1 changed the title feat/telemetry: added otel, persist settings to db, present user with the telemetry preferences & add privacy tab to settings feat(otel): added otel, persist settings to db, present user with the telemetry preferences & add privacy tab to settings May 1, 2025
Copy link
Copy Markdown

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mrge found 27 issues across 23 files. View them in mrge.io

Comment thread .gitignore Outdated
Comment thread sim/instrumentation.ts Outdated
Comment thread sim/app/telemetry-consent-dialog.tsx
Comment thread sim/instrumentation-client.ts
Comment thread sim/instrumentation-client.ts Outdated
@waleedlatif1 waleedlatif1 merged commit 03cde7e into main May 1, 2025
5 checks passed
RadoBoiii pushed a commit to RadoBoiii/sim-fork that referenced this pull request May 1, 2025
… telemetry preferences & add privacy tab to settings (simstudioai#318)

* feat(otel): added otel, persist settings to db, present user with the telemetry preferences & add privacy tab to settings

* updated telemetry endpoint

* add protected subdomains for chat deploy

* removed unused dependencies

* add execution telemetry logs for workflow-level and block-level logs, acknowledged PR comments
@waleedlatif1 waleedlatif1 deleted the feat/telemetry branch May 1, 2025 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant