-
Notifications
You must be signed in to change notification settings - Fork 3.3k
improvement(logs): skill icon for tool call #3181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Adds the AgentSkillsIcon to trace spans in logs when displaying the load_skill tool. Previously, skills appeared with a default gray color. Now they display with the proper skill icon and a purple (#8B5CF6) background color, consistent with the skills icon used in the settings modal and skill input components. Co-authored-by: Emir Karabeg <emir-karabeg@users.noreply.github.com>
|
Cursor Agent can help with this pull request. Just |
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Greptile OverviewGreptile SummaryAdded special handling for the Confidence Score: 5/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant TraceSpan
participant getBlockIconAndColor
participant Registry as Block Registry
participant Icons
TraceSpan->>getBlockIconAndColor: Request icon & color for span type
alt type === 'tool' && toolName
alt toolName === 'load_skill'
getBlockIconAndColor->>Icons: Get AgentSkillsIcon
Icons-->>getBlockIconAndColor: Return icon
getBlockIconAndColor-->>TraceSpan: {icon: AgentSkillsIcon, bgColor: '#8B5CF6'}
else other tool names
getBlockIconAndColor->>Registry: getBlockByToolName(toolName)
Registry-->>getBlockIconAndColor: Return block config
getBlockIconAndColor-->>TraceSpan: {icon, bgColor} from block
end
else Special types (loop, parallel, workflow)
getBlockIconAndColor-->>TraceSpan: {icon, bgColor} from special config
else Standard block types
getBlockIconAndColor->>Registry: getBlock(blockType)
Registry-->>getBlockIconAndColor: Return block config
getBlockIconAndColor-->>TraceSpan: {icon, bgColor} from block
end
TraceSpan->>TraceSpan: Render icon with background color
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 file reviewed, no comments
Summary
Adds the
AgentSkillsIconand a consistent purple background color to skill entries in the logs' trace spans. Previously, skill entries appeared with a generic gray icon due to missing specific handling for theload_skilltool.Fixes # (issue) - No specific issue number provided, remove if not applicable
Type of Change
Testing
The change was verified by running lint and type checks, which passed successfully. Visual inspection confirms the icon and color are now displayed correctly for skill blocks in the logs.
Checklist
Screenshots/Videos