Skip to content

fix(pagination): add missing next_page to response interfaces and operator comments#3236

Merged
waleedlatif1 merged 1 commit intostagingfrom
fix/pagination-followup
Feb 17, 2026
Merged

fix(pagination): add missing next_page to response interfaces and operator comments#3236
waleedlatif1 merged 1 commit intostagingfrom
fix/pagination-followup

Conversation

@waleedlatif1
Copy link
Collaborator

Summary

  • Add next_page to ZendeskAutocompleteOrganizationsResponse and ZendeskSearchUsersResponse paging interfaces to match runtime output
  • Add PostgREST operator mapping comment in Supabase text_search.ts for clarity

Type of Change

  • Bug fix

Testing

Tested manually

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel
Copy link

vercel bot commented Feb 17, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
docs Skipped Skipped Feb 17, 2026 10:05pm

Request Review

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Feb 17, 2026

Greptile Summary

Aligns TypeScript response interfaces with runtime API output by adding the missing next_page field to Zendesk pagination interfaces and clarifying PostgREST operator mappings in Supabase text search.

Changes

  • Added next_page?: string | null to ZendeskAutocompleteOrganizationsResponse and ZendeskSearchUsersResponse paging interfaces
  • Added comment explaining PostgREST operator abbreviations (plfts, phfts, wfts) in text_search.ts

Context

The Zendesk API returns a next_page URL in the response for offset pagination endpoints, and the shared PAGING_OUTPUT_PROPERTIES type in apps/sim/tools/zendesk/types.ts:412 already defines this field as optional. Other Zendesk tools like get_tickets.ts and get_organizations.ts properly include this field via the extractCursorPagingInfo() helper. This PR ensures consistency across all Zendesk pagination interfaces.

Confidence Score: 5/5

  • This PR is safe to merge with minimal risk
  • These are straightforward type-level fixes that add missing fields to match runtime behavior, with no logic changes. The added next_page field already exists in the shared types and is properly used in other Zendesk tools. The Supabase comment is purely documentation.
  • No files require special attention

Important Files Changed

Filename Overview
apps/sim/tools/supabase/text_search.ts Added clarifying comment for PostgREST operator mappings
apps/sim/tools/zendesk/autocomplete_organizations.ts Added missing next_page field to paging interface to match runtime output
apps/sim/tools/zendesk/search_users.ts Added missing next_page field to paging interface to match runtime output

Last reviewed commit: b7d2b04

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3 files reviewed, no comments

Edit Code Review Agent Settings | Greptile

@waleedlatif1 waleedlatif1 merged commit 3ce5414 into staging Feb 17, 2026
12 checks passed
@waleedlatif1 waleedlatif1 deleted the fix/pagination-followup branch February 17, 2026 22:13
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3 files reviewed, no comments

Edit Code Review Agent Settings | Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant