fix(chat): use explicit trigger type check instead of heuristic for chat guard

[waleedlatif1]

Summary

• Replace !isExecutingFromChat heuristic with explicit overrideTriggerType !== 'chat' check in execution completion callbacks
• The isExecutingFromChat heuristic ('input' in workflowInput) could false-positive for manual executions with a user-defined "input" test field, leaving isExecuting stuck true forever
• All 3 call sites of executeWorkflow always pass an explicit trigger type ('chat', 'manual'), so this check is deterministic

Type of Change

• Bug fix

Testing

Verified all 3 executeWorkflow call sites always pass explicit overrideTriggerType. Type check passes clean.

Checklist

• Code follows project style guidelines
• Self-reviewed my changes
• Tests added/updated and passing
• No new warnings introduced
• I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated (UTC)
docs	Skipped		Mar 5, 2026 3:01am

[cursor]

PR Summary

Low Risk
Low risk single-condition change in use-workflow-execution that affects when execution cleanup is skipped for chat runs; only risky if any caller fails to pass overrideTriggerType correctly.

Overview
Switches the isExecutingFromChat guard in use-workflow-execution.ts to rely solely on overrideTriggerType === 'chat', removing the heuristic that treated any workflowInput containing an input field as chat.

This prevents manual/test executions that happen to include an input key from being misclassified as chat and skipping the normal completion cleanup (e.g., leaving isExecuting stuck true).

^{Written by Cursor Bugbot for commit fec4793. Configure here.}

[greptile-apps]

Greptile Summary

This PR fixes a false-positive bug in the isExecutingFromChat guard inside executeWorkflow. The old implementation included a heuristic ('input' in workflowInput) that could match manual test executions with a user-defined input field, causing isExecuting to remain stuck as true after the run completed. The fix correctly replaces the compound condition with the deterministic overrideTriggerType === 'chat' check.

Key observations:

• All three internal call sites of executeWorkflow already supply an explicit overrideTriggerType ('chat' at line 942, 'manual' at line 1055, and 'manual' inline at line 2111), confirming the heuristic fallback was always dead code in practice.
• The overrideTriggerType parameter remains optional in the function signature. If a future caller omits it, isExecutingFromChat defaults to false, which is the safe outcome — state cleanup will run as normal rather than being skipped.
• The fix correctly preserves all downstream uses of isExecutingFromChat: streaming forwarding (line 1393), execution-completed cleanup guard (line 1499), error-path cleanup guard (line 1542), and cancellation-path cleanup guard (line 1568).

Confidence Score: 5/5

• This PR is safe to merge — it is a minimal, targeted bug fix with no risk of regression.
• The change is a single-line simplification that removes a provably incorrect heuristic. All three call sites pass an explicit trigger type, the logic is straightforward, and the default-to-false behavior for any future caller without an explicit type is the safer outcome. No new code paths are introduced.
• No files require special attention.

Important Files Changed

Filename	Overview
apps/sim/app/workspace/[workspaceId]/w/[workflowId]/hooks/use-workflow-execution.ts	Removes the heuristic 'input' in workflowInput fallback from the isExecutingFromChat guard, replacing it with the explicit overrideTriggerType === 'chat' check. All three call sites already pass an explicit trigger type, making the heuristic both redundant and a source of false positives.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[executeWorkflow called] --> B{overrideTriggerType?}
    B -- "'chat'" --> C[isExecutingFromChat = true]
    B -- "'manual' / 'api' / undefined" --> D[isExecutingFromChat = false]

    C --> E[Fetch selectedOutputs from chat store]
    C --> F[Find chat trigger start block]
    C --> G{onStream && isExecutingFromChat?}
    G -- yes --> H[Forward stream chunks to chat UI]
    G -- no --> I[Skip stream forwarding]

    D --> J[Resolve manual/API start block]

    C --> K[onExecutionCompleted]
    D --> K
    K -- isExecutingFromChat=true --> L[Skip setIsExecuting false\nchat finally-block handles cleanup]
    K -- isExecutingFromChat=false --> M[setIsExecuting false\nclearActiveBlocks]

    C --> N[onExecutionError / onExecutionCancelled]
    D --> N
    N -- isExecutingFromChat=true --> O[Skip state reset\nchat handles cleanup]
    N -- isExecutingFromChat=false --> P[setIsExecuting false\nsetIsDebugging false\nclearActiveBlocks]

Loading

_{Last reviewed commit: fec4793}

[waleedlatif1]

@greptile

[waleedlatif1]

@cursor review

[waleedlatif1]

@greptile

[waleedlatif1]

@cursor review

[cursor]

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR