Skip to content

fix(knowledge): fix search input flicker on clear and plan display name fallback #3810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
waleedlatif1 merged 1 commit into from
Mar 27, 2026
+14 −5
Merged

fix(knowledge): fix search input flicker on clear and plan display name fallback #3810

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions apps/sim/app/workspace/[workspaceId]/knowledge/knowledge.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,16 +60,22 @@ export function Knowledge() {
const { mutateAsync: updateKnowledgeBaseMutation } = useUpdateKnowledgeBase(workspaceId)
const { mutateAsync: deleteKnowledgeBaseMutation } = useDeleteKnowledgeBase(workspaceId)

const [searchInputValue, setSearchInputValue] = useState('')
const [debouncedSearchQuery, setDebouncedSearchQuery] = useState('')
const searchTimerRef = useRef<ReturnType<typeof setTimeout>>(null)

const handleSearchChange = useCallback((value: string) => {
setSearchInputValue(value)
if (searchTimerRef.current) clearTimeout(searchTimerRef.current)
searchTimerRef.current = setTimeout(() => {
setDebouncedSearchQuery(value)
}, 300)
}, [])

const handleSearchClearAll = useCallback(() => {
handleSearchChange('')
}, [handleSearchChange])

const [isCreateModalOpen, setIsCreateModalOpen] = useState(false)

const [activeKnowledgeBase, setActiveKnowledgeBase] = useState<KnowledgeBaseWithDocCount | null>(
Expand Down Expand Up @@ -256,12 +262,12 @@ export function Knowledge() {

const searchConfig: SearchConfig = useMemo(
() => ({
value: debouncedSearchQuery,
value: searchInputValue,
onChange: handleSearchChange,
onClearAll: () => handleSearchChange(''),
onClearAll: handleSearchClearAll,
placeholder: 'Search knowledge bases...',
}),
[handleSearchChange, debouncedSearchQuery]
[searchInputValue, handleSearchChange, handleSearchClearAll]
)

return (
Expand Down
7 changes: 5 additions & 2 deletions ...space/[workspaceId]/w/components/sidebar/components/workspace-header/workspace-header.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,8 +138,11 @@ export function WorkspaceHeader({
const currentPlan = subscriptionResponse?.data?.plan
const showPlanInfo = isBillingEnabled && typeof currentPlan !== 'undefined'
const rawPlanName = showPlanInfo ? getDisplayPlanName(currentPlan) : ''
const planDisplayName =
showPlanInfo && rawPlanName.includes('for Teams') ? rawPlanName : `${rawPlanName} Plan`
const planDisplayName = showPlanInfo
? rawPlanName.includes('for Teams')
? rawPlanName
: `${rawPlanName} Plan`
: ''
const isFreePlan = showPlanInfo && isFree(currentPlan)

// Listen for open-invite-modal event from context menu
Expand Down
Loading