feat(block): Conditionally hide impersonateUser field from block, add service account prompting#3966
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
@BugBot review |
PR SummaryMedium Risk Overview Updates Copilot Reviewed by Cursor Bugbot for commit fac34dc. Bugbot is set up for automated code reviews on this repo. Configure here. |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit fac34dc. Configure here.
Greptile SummaryThis PR fixes two bugs in the Google service account (
Confidence Score: 5/5Safe to merge — targeted bug fixes with no breaking changes All changes are targeted bug fixes. The reactive condition extraction is a pure refactor with identical behavior. The workflow-block.tsx change correctly applies the same filtering logic already in the editor panel. The Copilot metadata change safely adds an optional field. No P0/P1 issues found; the single P2 is a minor documentation gap, not a current defect. No files require special attention Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[Block subBlocks config] --> B[useReactiveConditions hook]
B --> C{subblock with\nreactiveCondition?}
C -- No --> D[Return empty Set]
C -- Yes --> E[Watch credential field\nvia useSubBlockStore]
E --> F[Fetch credential type\nvia useWorkspaceCredential]
F --> G{credential.type\n=== requiredType?}
G -- Match --> H[Condition met]
G -- No match --> I[Add subblock ID\nto hidden Set]
H --> J[Return hidden Set]
I --> J
J --> K[workflow-block.tsx\nsubBlockRowsData filter]
J --> L[use-editor-subblock-layout\nvisibleSubBlocks filter]
K --> M[Canvas: impersonateUser\nhidden correctly]
L --> N[Editor panel: impersonateUser\nhidden correctly]
Reviews (1): Last reviewed commit: "Fix lint" | Re-trigger Greptile |
Summary
useReactiveCondition. Extracted this to a helper method to be used in both locations.google, notgoogle-service-account. Added aservice-account-typeto the auth block to specific google, and we can extend this to other service account types in the future.Type of Change
Testing
Checklist
Screenshots/Videos