feat(teams-attachments): added support for teams attachments#412
Merged
waleedlatif1 merged 5 commits intosimstudioai:mainfrom May 25, 2025
Merged
feat(teams-attachments): added support for teams attachments#412waleedlatif1 merged 5 commits intosimstudioai:mainfrom
waleedlatif1 merged 5 commits intosimstudioai:mainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
|
Someone is attempting to deploy a commit to the Sim Studio Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
There was a problem hiding this comment.
PR Summary
This PR adds comprehensive support for Microsoft Teams attachments across the platform, enabling attachment handling in both chat and channel contexts.
- New
attachment-utils.tsintroducestransformAttachmentandextractMessageAttachmentsfunctions but uses unvalidatedanytypes that should be properly typed read_chat.tsandread_channel.tsneed error handling for malformed attachment data and validation of attachment URLs for securityMicrosoftTeamsAttachmentinterface intypes.tshas several optional fields that could benefit from stricter typingTeamsMessageSelectorcomponent uses channelId for message identification but should validate attachment metadata before display- Consider adding size limits and content type validation for attachments to prevent potential security issues
5 file(s) reviewed, 6 comment(s)
Edit PR Review Bot Settings | Greptile
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added support for teams attachments.
Type of change
How Has This Been Tested?
Ran the tools and saw the attachments there.
Checklist:
bun run test)Security Considerations: