Skip to content

feat(teams-attachments): added support for teams attachments#412

Merged
waleedlatif1 merged 5 commits intosimstudioai:mainfrom
aadamgough:feat/teams-attachments
May 25, 2025
Merged

feat(teams-attachments): added support for teams attachments#412
waleedlatif1 merged 5 commits intosimstudioai:mainfrom
aadamgough:feat/teams-attachments

Conversation

@aadamgough
Copy link
Contributor

Description

Added support for teams attachments.

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Ran the tools and saw the attachments there.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works
  • All tests pass locally and in CI (bun run test)
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • I have updated version numbers as needed (if needed)
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Security Considerations:

  • My changes do not introduce any new security vulnerabilities
  • I have considered the security implications of my changes

@vercel
Copy link

vercel bot commented May 25, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sim ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 25, 2025 5:01am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
docs ⬜️ Skipped (Inspect) May 25, 2025 5:01am

@vercel vercel bot temporarily deployed to Preview – docs May 25, 2025 04:50 Inactive
@vercel
Copy link

vercel bot commented May 25, 2025

Someone is attempting to deploy a commit to the Sim Studio Team on Vercel.

A member of the Team first needs to authorize it.

@aadamgough aadamgough marked this pull request as ready for review May 25, 2025 04:50
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This PR adds comprehensive support for Microsoft Teams attachments across the platform, enabling attachment handling in both chat and channel contexts.

  • New attachment-utils.ts introduces transformAttachment and extractMessageAttachments functions but uses unvalidated any types that should be properly typed
  • read_chat.ts and read_channel.ts need error handling for malformed attachment data and validation of attachment URLs for security
  • MicrosoftTeamsAttachment interface in types.ts has several optional fields that could benefit from stricter typing
  • TeamsMessageSelector component uses channelId for message identification but should validate attachment metadata before display
  • Consider adding size limits and content type validation for attachments to prevent potential security issues

5 file(s) reviewed, 6 comment(s)
Edit PR Review Bot Settings | Greptile

@vercel vercel bot temporarily deployed to Preview – docs May 25, 2025 04:56 Inactive
@waleedlatif1 waleedlatif1 merged commit 8ec194a into simstudioai:main May 25, 2025
5 checks passed
@aadamgough aadamgough deleted the feat/teams-attachments branch June 14, 2025 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants