fix(google-drive): add auto export format and validate against Drive API docs#4161
fix(google-drive): add auto export format and validate against Drive API docs#4161waleedlatif1 merged 7 commits intostagingfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
PR SummaryMedium Risk Overview The download API now validates requested export formats against a new Reviewed by Cursor Bugbot for commit 291b2ee. Configure here. |
Greptile SummaryFixes two incorrect Confidence Score: 5/5Safe to merge — all format fixes are correct per Google Drive API docs and the validation logic is sound. All remaining findings are P2 UX suggestions. The core bug fixes (Forms/Apps Script default formats) are verified against the official docs, the validation logic correctly guards against invalid API calls, and the apps/sim/blocks/blocks/google_drive.ts — the dropdown's HTML option will now surface a validation error for Sheets/Slides since the expected format is application/zip, not text/html. Important Files Changed
Reviews (3): Last reviewed commit: "fix(google-drive): add text/markdown to ..." | Re-trigger Greptile |
82180e0 to
40f3b45
Compare
|
@greptile |
|
@cursor review |
|
@greptile |
|
@cursor review |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 291b2ee. Configure here.
Summary
autovalue in block params so it can't leak to create_file/upload operationsVALID_EXPORT_FORMATSmap based on Google Drive API docs to validate requested formats before calling the APIDEFAULT_EXPORT_FORMATSfor Forms (application/zipnotapplication/pdf) and Apps Script (application/vnd.google-apps.script+jsonnotapplication/json)Type of Change
Testing
Tested manually
Checklist