fix(landing): return 404 for invalid dynamic route slugs#4182
fix(landing): return 404 for invalid dynamic route slugs#4182waleedlatif1 merged 3 commits intostagingfrom
Conversation
Add `dynamicParams = false` to all landing page dynamic routes so Next.js returns a proper 404 instead of a client-side exception for slugs not in generateStaticParams. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
PR SummaryLow Risk Overview This makes invalid Reviewed by Cursor Bugbot for commit 33c29cc. Configure here. |
Greptile SummaryAdds Confidence Score: 5/5Safe to merge — minimal, targeted change that applies the standard Next.js pattern for 404-on-unknown-slugs across all landing dynamic routes. All four files receive only the single-line No files require special attention. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[Incoming Request\nfor dynamic slug] --> B{slug in\ngenerateStaticParams?}
B -- Yes --> C[Render static page\n/ revalidate if stale]
B -- No --> D[dynamicParams = false\nNext.js returns 404]
D --> E[Custom 404 page shown]
C --> F[Page rendered successfully]
Reviews (2): Last reviewed commit: "fix(home): remove duplicate handleStopGe..." | Re-trigger Greptile |
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
@greptile |
|
@cursor review |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 33c29cc. Configure here.
…mat, logs performance improvements fix(csp): add missing analytics domains, remove unsafe-eval, fix workspace CSP gap (#4179) fix(landing): return 404 for invalid dynamic route slugs (#4182) improvement(seo): optimize sitemaps, robots.txt, and core web vitals across sim and docs (#4170) fix(gemini): support structured output with tools on Gemini 3 models (#4184) feat(brightdata): add Bright Data integration with 8 tools (#4183) fix(mothership): fix superagent credentials (#4185) fix(logs): close sidebar when selected log disappears from filtered list; cleanup (#4186)
Summary
dynamicParams = falseto all landing page dynamic routes (integrations, models, blog)Type of Change
Testing
Tested manually
Checklist