fix(resolver): turn off resolver for opaque schema nodes, unrun paths#4208
fix(resolver): turn off resolver for opaque schema nodes, unrun paths#4208icecrasher321 merged 3 commits intostagingfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
PR SummaryMedium Risk Overview Schema-path validation now treats
Reviewed by Cursor Bugbot for commit 4d410ad. Configure here. |
Greptile SummaryThis PR fixes two related bugs where the block reference resolver threw Confidence Score: 5/5Safe to merge — all findings are P2 style issues in the new test file only. The production logic changes are well-reasoned, correctly implemented, and backed by targeted unit and integration tests. The three comments are minor test-file style issues (missing environment directive, relative import, apps/sim/executor/utils/subflow-utils.test.ts — relative import, missing @vitest-environment node, and as any cast. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[resolveBlockReference called] --> B{blockId found?}
B -- No --> C[return undefined]
B -- Yes --> D{blockOutput === undefined?}
D -- Yes\n(block not executed / branched path) --> E[return value: undefined\nno schema validation]
D -- No --> F{pathParts empty?}
F -- Yes --> G[return full blockOutput]
F -- No --> H[navigatePath through blockOutput]
H --> I{value === undefined?}
I -- No --> J[return value]
I -- Yes --> K{schema exists?}
K -- No --> J
K -- Yes --> L[isPathInSchema check]
L --> M{path valid?}
M -- Yes --> J
M -- No --> N[throw InvalidFieldError]
subgraph isPathInSchema
O[walk schema nodes] --> P{isOpaqueSchemaNode?\ntype: json/object/any\nwithout properties}
P -- Yes --> Q[return true\nany sub-path accepted]
P -- No --> R[lookupField / array traversal]
R --> S{field found?}
S -- No --> T[return false]
S -- Yes --> O
end
Reviews (1): Last reviewed commit: "fix subflows to make them consistent" | Re-trigger Greptile |
Summary
Turn off InvalidFieldErrors for:
Type of Change
Testing
Tested manually and added tests.
Checklist