Skip to content

fix(loop-ui): fixed some UI issues, added tests for parallel and loop nodes#421

Merged
waleedlatif1 merged 5 commits intosimstudioai:mainfrom
aadamgough:fix/loop-ui
May 26, 2025
Merged

fix(loop-ui): fixed some UI issues, added tests for parallel and loop nodes#421
waleedlatif1 merged 5 commits intosimstudioai:mainfrom
aadamgough:fix/loop-ui

Conversation

@aadamgough
Copy link
Contributor

Description

Fixed UI issues with resizing the node, dragging content into the node, and auto connecting the nodes.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Confirmed that each change I made worked on both the parallel and loop nodes. I also wrote two test files.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works
  • All tests pass locally and in CI (bun run test)
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • I have updated version numbers as needed (if needed)
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Security Considerations:

  • My changes do not introduce any new security vulnerabilities
  • I have considered the security implications of my changes

@vercel
Copy link

vercel bot commented May 26, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sim ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 26, 2025 6:39pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
docs ⬜️ Skipped (Inspect) May 26, 2025 6:39pm

@vercel vercel bot temporarily deployed to Preview – docs May 26, 2025 18:03 Inactive
@vercel
Copy link

vercel bot commented May 26, 2025

Someone is attempting to deploy a commit to the Sim Studio Team on Vercel.

A member of the Team first needs to authorize it.

@vercel vercel bot temporarily deployed to Preview – docs May 26, 2025 18:15 Inactive
@aadamgough aadamgough marked this pull request as ready for review May 26, 2025 18:22
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This PR addresses UI issues in loop and parallel nodes with comprehensive test coverage. Here are the key changes:

  • Improved container node resizing by removing problematic CSS transitions and adding proper dimension calculations with padding to prevent sidebar overlap
  • Enhanced drag-and-drop functionality with better event propagation control and parent-child relationship handling
  • Added proper source handle determination for loop/parallel nodes using specific handles ('loop-end-source'/'parallel-end-source')
  • Added comprehensive test suites for both loop and parallel nodes covering component structure, props validation, and edge cases
  • Fixed auto-connection logic for nested nodes by prioritizing container start nodes and preventing invalid connections

8 file(s) reviewed, 6 comment(s)
Edit PR Review Bot Settings | Greptile

@vercel vercel bot temporarily deployed to Preview – docs May 26, 2025 18:35 Inactive
@waleedlatif1 waleedlatif1 merged commit ad4060a into simstudioai:main May 26, 2025
5 checks passed
@aadamgough aadamgough changed the title fit(loop-ui): fixed some UI issues, added tests for parallel and loop nodes fix(loop-ui): fixed some UI issues, added tests for parallel and loop nodes May 26, 2025
@aadamgough aadamgough deleted the fix/loop-ui branch June 14, 2025 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants