fix(loop-ui): fixed some UI issues, added tests for parallel and loop nodes#421
Merged
waleedlatif1 merged 5 commits intosimstudioai:mainfrom May 26, 2025
Merged
Conversation
added 3 commits
May 26, 2025 11:00
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
|
Someone is attempting to deploy a commit to the Sim Studio Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
There was a problem hiding this comment.
PR Summary
This PR addresses UI issues in loop and parallel nodes with comprehensive test coverage. Here are the key changes:
- Improved container node resizing by removing problematic CSS transitions and adding proper dimension calculations with padding to prevent sidebar overlap
- Enhanced drag-and-drop functionality with better event propagation control and parent-child relationship handling
- Added proper source handle determination for loop/parallel nodes using specific handles ('loop-end-source'/'parallel-end-source')
- Added comprehensive test suites for both loop and parallel nodes covering component structure, props validation, and edge cases
- Fixed auto-connection logic for nested nodes by prioritizing container start nodes and preventing invalid connections
8 file(s) reviewed, 6 comment(s)
Edit PR Review Bot Settings | Greptile
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixed UI issues with resizing the node, dragging content into the node, and auto connecting the nodes.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Confirmed that each change I made worked on both the parallel and loop nodes. I also wrote two test files.
Checklist:
bun run test)Security Considerations: