Skip to content

fix(settings): hide data-retention nav item when user lacks enterprise plan#4256

Merged
waleedlatif1 merged 1 commit intostagingfrom
fix/data-retention-nav-visibility
Apr 22, 2026
Merged

fix(settings): hide data-retention nav item when user lacks enterprise plan#4256
waleedlatif1 merged 1 commit intostagingfrom
fix/data-retention-nav-visibility

Conversation

@waleedlatif1
Copy link
Copy Markdown
Collaborator

Summary

  • Removes showWhenLocked: true from the Data Retention nav item so it follows the same visibility rules as all other enterprise features (SSO, Whitelabeling, Audit Logs, Access Control)
  • Previously, Data Retention was visible to users without an enterprise plan; all other enterprise nav items are hidden until the plan requirement is met

Type of Change

  • Bug fix

Testing

Tested manually

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel
Copy link
Copy Markdown

vercel Bot commented Apr 22, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
docs Skipped Skipped Apr 22, 2026 3:17am

Request Review

@cursor
Copy link
Copy Markdown

cursor Bot commented Apr 22, 2026

PR Summary

Low Risk
Low risk UI/navigation visibility tweak that only changes when the data-retention settings link is shown based on plan gating.

Overview
Aligns the Data Retention settings navigation item with other enterprise-only items by removing showWhenLocked, so it no longer appears in the sidebar for workspaces without an enterprise plan (instead of showing an upgrade-locked entry).

Reviewed by Cursor Bugbot for commit 3728d2b. Configure here.

@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented Apr 22, 2026

Greptile Summary

This PR removes showWhenLocked: true from the data-retention nav item in navigation.ts, making its visibility behavior consistent with the other enterprise-gated features (SSO, Whitelabeling, Audit Logs, Access Control). The change is a one-line fix with a clear and accurate description.

Confidence Score: 5/5

Safe to merge — single-line config fix with no logic changes or side effects.

The change is minimal, correct, and aligns Data Retention's visibility with every other enterprise nav item. No logic, API, or data-flow changes are involved.

No files require special attention.

Important Files Changed

Filename Overview
apps/sim/app/workspace/[workspaceId]/settings/navigation.ts Removes showWhenLocked: true from the data-retention nav item so it is hidden for non-enterprise users, consistent with all other enterprise feature nav items.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[Render settings sidebar] --> B{requiresEnterprise?}
    B -- No --> C[Always show item]
    B -- Yes --> D{showWhenLocked?}
    D -- true --> E[Show with upgrade badge]
    D -- false / absent --> F{User has enterprise plan?}
    F -- Yes --> G[Show item]
    F -- No --> H[Hide item]

    subgraph Before this PR
        DR_before[data-retention showWhenLocked: true] --> E
    end

    subgraph After this PR
        DR_after[data-retention no showWhenLocked] --> F
    end
Loading

Reviews (1): Last reviewed commit: "fix(settings): hide data-retention nav i..." | Re-trigger Greptile

@waleedlatif1 waleedlatif1 merged commit c2529c3 into staging Apr 22, 2026
10 checks passed
@waleedlatif1 waleedlatif1 deleted the fix/data-retention-nav-visibility branch April 22, 2026 03:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant