-
Notifications
You must be signed in to change notification settings - Fork 3.5k
feat(logs): trace span tree rewrite with resizable split, provider icons, and execution improvements #4292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
feat(logs): trace span tree rewrite with resizable split, provider icons, and execution improvements #4292
Changes from all commits
Commits
Show all changes
30 commits
Select commit
Hold shift + click to select a range
cf26f00
improvement(trace-spans): rewrite trace span pipeline with per-iterat…
waleedlatif1 94a9d62
improvement(logs): add Trace tab with two-pane tree+detail view
waleedlatif1 205ed3e
feat(logs): retry failed runs + show workflow input in detail
waleedlatif1 2d2350b
fix(ui): use inverted popover scheme for usage-control popovers
waleedlatif1 71d1a2b
fix(logs): trace view chevron padding, section state leak, and tab-sc…
waleedlatif1 8ea3e87
fix(logs): align trace tree rows to 14px content grid
waleedlatif1 b742f7e
fix(logs): restore scroll in log-details panel
waleedlatif1 e43a9cf
fix(logs): hide inactive Overview tab panel
waleedlatif1 07a0ef5
fix(logs): trace view padding, section cutoff, keyboard visibility
waleedlatif1 60a79da
fix(logs): inline Workflow State row and lift search dropdown z-index
waleedlatif1 d0af5d9
fix(logs): use emcn Button for View Snapshot action
waleedlatif1 fcafc5b
minor improvements
waleedlatif1 42749ab
fix(logs): trace view resizable split, bar visibility, provider icons…
waleedlatif1 b442253
fix(ui): scroll guard, credentials UX, design token fixes, input padding
waleedlatif1 0dc06d0
chore(skills): add /ship command to claude, cursor, and agents
waleedlatif1 31843aa
fix(input): add scroll-pr-1 to keep caret visible when text overflows
waleedlatif1 220b27f
fix(logs): address PR review — iteration name guard, cost race, mothe…
waleedlatif1 2bed48a
improvement(logs): cleanup pass — remove anti-patterns, fix design to…
waleedlatif1 267d3ae
fix(trace-spans): extend final model segment by position not by stale…
waleedlatif1 5841ca0
fix(modal): restore sidebar-width padding on non-workflow pages
waleedlatif1 4870ef7
fix(secrets): eliminate slow save by parallelizing DB ops and fixing …
waleedlatif1 197260e
updated sap block
waleedlatif1 5b31df7
fix(sap): remove slash from S4HANA name, set white bgColor, regenerat…
waleedlatif1 6636e70
fix(logs): prevent log-row arrow navigation when trace tab is active
waleedlatif1 64fb611
fix(logs): aggregate cost onto workflow root span; stabilize onActive…
waleedlatif1 3bde902
improvement(logs): fix Gantt time bounds to walk full span tree; clea…
waleedlatif1 bb40841
fix(logs): reset detail panel tab to overview on log switch
waleedlatif1 bab34fa
chore(logs): remove extraneous comments
waleedlatif1 3aa372f
fix(logs): restore useEffect for async setActiveWorkflow and useMemo …
waleedlatif1 e978cb5
fix(queries): forward AbortSignal in mothership-admin query functions
waleedlatif1 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,82 @@ | ||
| --- | ||
| name: ship | ||
| description: Commit, push, and open a PR to staging in one shot | ||
| --- | ||
|
|
||
| # Ship Command | ||
|
|
||
| You help ship code by creating commits, pushing to the remote branch, and creating PRs in the user's voice. | ||
|
|
||
| ## Your Task | ||
|
|
||
| When the user runs `/ship`: | ||
|
|
||
| 1. **Check git status** - See what files have changed | ||
| 2. **Generate a commit message** following this format: `type(scope): description` | ||
| - Types: `fix`, `feat`, `improvement`, `chore` | ||
| - Scope: short identifier (e.g., `undo-redo`, `api`, `ui`) | ||
| - Keep it concise | ||
|
|
||
| 3. **Run lint** - Run `bun run lint` from the repo root to fix formatting issues before staging | ||
|
|
||
| 4. **Stage and commit** the changes with the generated message | ||
|
|
||
| 5. **Push to origin** using the current branch name | ||
|
|
||
| 6. **Create a PR** to staging with a description in the user's voice | ||
|
|
||
| ## Commit Message Format | ||
|
|
||
| Based on the repo's commit history: | ||
| ``` | ||
| fix(scope): description for bug fixes | ||
| feat(scope): description for new features | ||
| improvement(scope): description for enhancements | ||
| chore(scope): description for maintenance | ||
| ``` | ||
|
|
||
| ## PR Description Format | ||
|
|
||
| Use this exact template in the user's voice (concise, bullet points): | ||
|
|
||
| ```markdown | ||
| ## Summary | ||
| - bullet point describing what changed | ||
| - another bullet point if needed | ||
|
|
||
| ## Type of Change | ||
| - [x] Bug fix (or appropriate type) | ||
|
|
||
| ## Testing | ||
| Tested manually (or describe testing) | ||
|
|
||
| ## Checklist | ||
| - [x] Code follows project style guidelines | ||
| - [x] Self-reviewed my changes | ||
| - [ ] Tests added/updated and passing | ||
| - [x] No new warnings introduced | ||
| - [x] I confirm that I have read and agree to the terms outlined in the [Contributor License Agreement (CLA)](./CONTRIBUTING.md#contributor-license-agreement-cla) | ||
| ``` | ||
|
|
||
| ## PR Creation Command | ||
|
|
||
| Use this command structure: | ||
| ```bash | ||
| gh pr create --base staging --title "COMMIT_MESSAGE" --body "PR_BODY" | ||
| ``` | ||
|
|
||
| ## Important Notes | ||
|
|
||
| - Always confirm the commit message and PR description with the user before executing | ||
| - The PR should be created against `staging` branch | ||
| - Keep descriptions concise and in active voice | ||
| - Match the user's previous PR style: direct, no fluff, bullet points | ||
| - **DO NOT add "Co-Authored-By" lines to commits** - keep commit messages clean | ||
|
|
||
| ## User's Voice Characteristics (based on previous PRs) | ||
|
|
||
| - Short, direct bullet points | ||
| - No unnecessary explanation | ||
| - "Tested manually" is acceptable for testing section | ||
| - Checkboxes filled in appropriately | ||
| - No screenshots section unless UI changes | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,82 @@ | ||
| --- | ||
| description: Commit, push, and open a PR to staging in one shot | ||
| argument-hint: [optional context or scope notes] | ||
| --- | ||
|
|
||
| # Ship Command | ||
|
|
||
| You help ship code by creating commits, pushing to the remote branch, and creating PRs in the user's voice. | ||
|
|
||
| ## Your Task | ||
|
|
||
| When the user runs `/ship`: | ||
|
|
||
| 1. **Check git status** - See what files have changed | ||
| 2. **Generate a commit message** following this format: `type(scope): description` | ||
| - Types: `fix`, `feat`, `improvement`, `chore` | ||
| - Scope: short identifier (e.g., `undo-redo`, `api`, `ui`) | ||
| - Keep it concise | ||
|
|
||
| 3. **Run lint** - Run `bun run lint` from the repo root to fix formatting issues before staging | ||
|
|
||
| 4. **Stage and commit** the changes with the generated message | ||
|
|
||
| 5. **Push to origin** using the current branch name | ||
|
|
||
| 6. **Create a PR** to staging with a description in the user's voice | ||
|
|
||
| ## Commit Message Format | ||
|
|
||
| Based on the repo's commit history: | ||
| ``` | ||
| fix(scope): description for bug fixes | ||
| feat(scope): description for new features | ||
| improvement(scope): description for enhancements | ||
| chore(scope): description for maintenance | ||
| ``` | ||
|
|
||
| ## PR Description Format | ||
|
|
||
| Use this exact template in the user's voice (concise, bullet points): | ||
|
|
||
| ```markdown | ||
| ## Summary | ||
| - bullet point describing what changed | ||
| - another bullet point if needed | ||
|
|
||
| ## Type of Change | ||
| - [x] Bug fix (or appropriate type) | ||
|
|
||
| ## Testing | ||
| Tested manually (or describe testing) | ||
|
|
||
| ## Checklist | ||
| - [x] Code follows project style guidelines | ||
| - [x] Self-reviewed my changes | ||
| - [ ] Tests added/updated and passing | ||
| - [x] No new warnings introduced | ||
| - [x] I confirm that I have read and agree to the terms outlined in the [Contributor License Agreement (CLA)](./CONTRIBUTING.md#contributor-license-agreement-cla) | ||
| ``` | ||
|
|
||
| ## PR Creation Command | ||
|
|
||
| Use this command structure: | ||
| ```bash | ||
| gh pr create --base staging --title "COMMIT_MESSAGE" --body "PR_BODY" | ||
| ``` | ||
|
|
||
| ## Important Notes | ||
|
|
||
| - Always confirm the commit message and PR description with the user before executing | ||
| - The PR should be created against `staging` branch | ||
| - Keep descriptions concise and in active voice | ||
| - Match the user's previous PR style: direct, no fluff, bullet points | ||
| - **DO NOT add "Co-Authored-By" lines to commits** - keep commit messages clean | ||
|
|
||
| ## User's Voice Characteristics (based on previous PRs) | ||
|
|
||
| - Short, direct bullet points | ||
| - No unnecessary explanation | ||
| - "Tested manually" is acceptable for testing section | ||
| - Checkboxes filled in appropriately | ||
| - No screenshots section unless UI changes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,77 @@ | ||
| # Ship Command | ||
|
|
||
| You help ship code by creating commits, pushing to the remote branch, and creating PRs in the user's voice. | ||
|
|
||
| ## Your Task | ||
|
|
||
| When the user runs `/ship`: | ||
|
|
||
| 1. **Check git status** - See what files have changed | ||
| 2. **Generate a commit message** following this format: `type(scope): description` | ||
| - Types: `fix`, `feat`, `improvement`, `chore` | ||
| - Scope: short identifier (e.g., `undo-redo`, `api`, `ui`) | ||
| - Keep it concise | ||
|
|
||
| 3. **Run lint** - Run `bun run lint` from the repo root to fix formatting issues before staging | ||
|
|
||
| 4. **Stage and commit** the changes with the generated message | ||
|
|
||
| 5. **Push to origin** using the current branch name | ||
|
|
||
| 6. **Create a PR** to staging with a description in the user's voice | ||
|
|
||
| ## Commit Message Format | ||
|
|
||
| Based on the repo's commit history: | ||
| ``` | ||
| fix(scope): description for bug fixes | ||
| feat(scope): description for new features | ||
| improvement(scope): description for enhancements | ||
| chore(scope): description for maintenance | ||
| ``` | ||
|
|
||
| ## PR Description Format | ||
|
|
||
| Use this exact template in the user's voice (concise, bullet points): | ||
|
|
||
| ```markdown | ||
| ## Summary | ||
| - bullet point describing what changed | ||
| - another bullet point if needed | ||
|
|
||
| ## Type of Change | ||
| - [x] Bug fix (or appropriate type) | ||
|
|
||
| ## Testing | ||
| Tested manually (or describe testing) | ||
|
|
||
| ## Checklist | ||
| - [x] Code follows project style guidelines | ||
| - [x] Self-reviewed my changes | ||
| - [ ] Tests added/updated and passing | ||
| - [x] No new warnings introduced | ||
| - [x] I confirm that I have read and agree to the terms outlined in the [Contributor License Agreement (CLA)](./CONTRIBUTING.md#contributor-license-agreement-cla) | ||
| ``` | ||
|
|
||
| ## PR Creation Command | ||
|
|
||
| Use this command structure: | ||
| ```bash | ||
| gh pr create --base staging --title "COMMIT_MESSAGE" --body "PR_BODY" | ||
| ``` | ||
|
|
||
| ## Important Notes | ||
|
|
||
| - Always confirm the commit message and PR description with the user before executing | ||
| - The PR should be created against `staging` branch | ||
| - Keep descriptions concise and in active voice | ||
| - Match the user's previous PR style: direct, no fluff, bullet points | ||
| - **DO NOT add "Co-Authored-By" lines to commits** - keep commit messages clean | ||
|
|
||
| ## User's Voice Characteristics (based on previous PRs) | ||
|
|
||
| - Short, direct bullet points | ||
| - No unnecessary explanation | ||
| - "Tested manually" is acceptable for testing section | ||
| - Checkboxes filled in appropriately | ||
| - No screenshots section unless UI changes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.