improvement(kb-selector): add search to knowledge base selector subblock#4351
improvement(kb-selector): add search to knowledge base selector subblock#4351waleedlatif1 merged 1 commit intostagingfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
PR SummaryLow Risk Overview Reviewed by Cursor Bugbot for commit 8106798. Configure here. |
Greptile SummaryThis PR adds search functionality to the knowledge base selector subblock by passing Confidence Score: 5/5Safe to merge — two-line additive change using pre-existing, well-tested Combobox props. The change is minimal and purely additive. Both No files require special attention. Important Files Changed
Sequence DiagramsequenceDiagram
participant User
participant KnowledgeBaseSelector
participant Combobox
participant SearchInput
User->>KnowledgeBaseSelector: Opens dropdown
KnowledgeBaseSelector->>Combobox: searchable=true, searchPlaceholder="Search knowledge bases..."
Combobox->>SearchInput: Renders search input (auto-focused)
User->>SearchInput: Types query
SearchInput->>Combobox: setSearchQuery(query)
Combobox->>Combobox: filteredOptions = options.filter(label/value includes query)
Combobox-->>User: Shows filtered knowledge base options
User->>Combobox: Selects option
Combobox->>KnowledgeBaseSelector: onChange / onMultiSelectChange
Combobox->>Combobox: setSearchQuery('') — resets search
Reviews (1): Last reviewed commit: "improvement(kb-selector): add search to ..." | Re-trigger Greptile |
Summary
searchable+ placeholder on the Combobox)Type of Change
Testing
Tested manually
Checklist